[OFBIZ-7426] Enforce noninstantiability to SeoConfigUtil class

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: 16.11.01
• Component/s: product
• Sprint: Community Day 2 - 2016, OFBiz Community Day (May 2020)
• Assignee: Arun Patidar
• Reporter: Rishi Solanki
• Created: 18/Jun/16 09:51
• Updated: 29/Jun/16 04:55
• Resolved: 28/Jun/16 14:23

Description

• Make class as final.
• Add a private constructor.
• Make the following public variables as final

      public static String module = UtilAccounting.class.getName();
  

• Make the following public static variables as private

      public static final String DEFAULT_REGEXP = "^.*/.*$";
      public static final String ELEMENT_REGEXPIFMATCH = "regexpifmatch";
      public static final String ELEMENT_URL_CONFIG = "url-config";
      public static final String ELEMENT_DESCRIPTION = "description";
      public static final String ELEMENT_FORWARD = "forward";
      public static final String ELEMENT_SEO = "seo";
      public static final String ELEMENT_URLPATTERN = "url-pattern";
      public static final String ELEMENT_REPLACEMENT = "replacement";
      public static final String ELEMENT_RESPONSECODE = "responsecode";
      public static final String ELEMENT_JSESSIONID = "jsessionid";
      public static final String ELEMENT_ANONYMOUS = "anonymous";
      public static final String ELEMENT_VALUE = "value";
      public static final String ELEMENT_USER = "user";
      public static final String ELEMENT_EXCEPTIONS = "exceptions";
      public static final String ELEMENT_CHAR_FILTERS = "char-filters";
      public static final String ELEMENT_CHAR_FILTER = "char-filter";
      public static final String ELEMENT_CHARACTER_PATTERN = "character-pattern";
      public static final String ELEMENT_CATEGORY_URL = "category-url";
      public static final String ELEMENT_ALLOWED_CONTEXT_PATHS = "allowed-context-paths";
      public static final String ELEMENT_CATEGORY_NAME = "category-name";
      public static final String ELEMENT_CATEGORY_URL_SUFFIX = "category-url-suffix";
      public static final String SEO_CONFIG_FILENAME = "SeoConfig.xml";
      public static final int DEFAULT_RESPONSECODE = HttpServletResponse.SC_MOVED_PERMANENTLY;
      public static final String DEFAULT_ANONYMOUS_VALUE = "disable";
      public static final String DEFAULT_USER_VALUE = "disable";
      public static final String DEFAULT_CATEGORY_URL_VALUE = "enable";
      public static final String DEFAULT_CATEGORY_NAME_VALUE = "disable";
      public static final String ALLOWED_CONTEXT_PATHS_SEPERATOR = ":";
  
  

• Also add getDefaultResponseCode() method for following variable after making it private and use it in UrlRegexpTransform.java, SeoContextFilter.java and UrlRegexpContextFilter.java

    public static final int DEFAULT_RESPONSECODE = HttpServletResponse.SC_MOVED_PERMANENTLY;