Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7374

Add capability to Expire or Remove the added content for a party

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 16.11.01
    • Component/s: party
    • Labels:
      None
    • Sprint:
      Community Day 2 - 2016

      Description

      Currently when any content is uploaded/added with respect to any party via Party Manager >> Parties >> Party Content tab, there is no option for user to Expire or remove such added content in any form

      We could try adding this feature that could allow user to

      1. Expire any content by setting thru_date to now() on click of "Expire" button against each content row
      2. Or option to update the From/Thru date by showing these dates as editable against each content row
      3. Remove any added content on click of a "Delete" button
        (Please refer to attached screenshot for reference)
      1. EditPartyContent.png
        59 kB
        Ankush Upadhyay
      2. OFBIZ-7374.patch
        6 kB
        Ankush Upadhyay
      3. Party_content_1.png
        126 kB
        Swapnil Shah

        Activity

        Hide
        rishisolankii Rishi Solanki added a comment -

        On view profile under Party Content screenlet we have this functionality from where user can remove the Party Content. Ideally it should expire the record on click on remove. So we should try to cover this at both places and match the functionality, that means from both locations system should either expires the record or remove it.

        Recommendation is to expire from both places. Thanks!

        Show
        rishisolankii Rishi Solanki added a comment - On view profile under Party Content screenlet we have this functionality from where user can remove the Party Content. Ideally it should expire the record on click on remove. So we should try to cover this at both places and match the functionality, that means from both locations system should either expires the record or remove it. Recommendation is to expire from both places. Thanks!
        Hide
        ankush.upadhyay Ankush Upadhyay added a comment -

        I have added support to create party content by providing fromDate and thruDate at the time of creation (currently there is no option to set fromDate and thruDate) and at the time of edit, user can change thruDate to choose / update expiration date.
        Also added support to remove content from Party Content tab so user can remove content from this tab as well.

        Attached screenshot for improved functionality.

        Show
        ankush.upadhyay Ankush Upadhyay added a comment - I have added support to create party content by providing fromDate and thruDate at the time of creation (currently there is no option to set fromDate and thruDate) and at the time of edit, user can change thruDate to choose / update expiration date. Also added support to remove content from Party Content tab so user can remove content from this tab as well. Attached screenshot for improved functionality.
        Hide
        ankush.upadhyay Ankush Upadhyay added a comment -

        Thanks Rishi Solanki for the suggestion. Yes, we have option to remove party content from Party Profile page. But we don't have option to choose content activation/expiration date.

        IMO we can keep remove functionality same so that user can delete unused contents if the user wishes to clean-up content's which are no longer in use.

        Following are the improvements done in provided patch:
        1. Added support to remove content from Party Content tab.
        2. Added fromDate, thruDate fields while creating content so now user can select content activation / expire date time.
        3. In case of update make thruDate editable so that user can select expiration date time.

        Show
        ankush.upadhyay Ankush Upadhyay added a comment - Thanks Rishi Solanki for the suggestion. Yes, we have option to remove party content from Party Profile page. But we don't have option to choose content activation/expiration date. IMO we can keep remove functionality same so that user can delete unused contents if the user wishes to clean-up content's which are no longer in use. Following are the improvements done in provided patch: 1. Added support to remove content from Party Content tab. 2. Added fromDate, thruDate fields while creating content so now user can select content activation / expire date time. 3. In case of update make thruDate editable so that user can select expiration date time.
        Hide
        diveshdut Divesh Dutta added a comment -

        Thanks Ankush Upadhyay for your patch, its committed in revision number 1749091 in trunk. Thanks Swapnil Shah for suggesting this improvement. I am assigning this ticket to you for testing and closure.

        Show
        diveshdut Divesh Dutta added a comment - Thanks Ankush Upadhyay for your patch, its committed in revision number 1749091 in trunk. Thanks Swapnil Shah for suggesting this improvement. I am assigning this ticket to you for testing and closure.
        Hide
        swash78 Swapnil Shah added a comment -

        Thanks Ankush Upadhyay I have tested the fixes and found them working fine:

        Unit Tests:

        1. Expired the existing content by setting thru dateand it stopped getting applied (PASS)
        2. Added content with from date in future and it didn't get applied (PASS)
        3. Added content with from date in past and it correctly got applied (PASS)
        Show
        swash78 Swapnil Shah added a comment - Thanks Ankush Upadhyay I have tested the fixes and found them working fine: Unit Tests: Expired the existing content by setting thru dateand it stopped getting applied ( PASS ) Added content with from date in future and it didn't get applied ( PASS ) Added content with from date in past and it correctly got applied ( PASS )

          People

          • Assignee:
            swash78 Swapnil Shah
            Reporter:
            swash78 Swapnil Shah
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile