Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7330

Error with Agreement Item Supplier product Pdf

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: accounting, product
    • Labels:
      None

      Description

      Steps to regenerate:
      1) Go to Accounting -> Agreements
      2) Find a purchase agreement and go to the List Agreement Items page.
      3) Go to edit any agreement item and then products page.
      4) Error with pdf generation when there are no products associated.

        Activity

        Hide
        lodhiravi Ravi Lodhi added a comment -

        To avoid the problem added an empty row inside table body. Uploaded patch for review.

        Show
        lodhiravi Ravi Lodhi added a comment - To avoid the problem added an empty row inside table body. Uploaded patch for review.
        Hide
        pfm.smits Pierre Smits added a comment -

        The issue seems to be related to an accounting specific pdf rendering problem, whereas the patch changes a generic rendering template.

        Are we sure this is the way to go? Why not generate a proper try/catch solution in the agreement specific rendering?

        Show
        pfm.smits Pierre Smits added a comment - The issue seems to be related to an accounting specific pdf rendering problem, whereas the patch changes a generic rendering template. Are we sure this is the way to go? Why not generate a proper try/catch solution in the agreement specific rendering?
        Hide
        lodhiravi Ravi Lodhi added a comment -

        Hi Pierre Smits

        This issue is a generic issue, which exists in all other places where list form is used for generating pdf.
        Some of the places are -
        1) Approved Product Requirements Pdf (ordermgr/control/ApprovedProductRequirements)
        2) Facility Inventory By Product Pdf (facility/control/ViewFacilityInventoryByProduct)

        Show
        lodhiravi Ravi Lodhi added a comment - Hi Pierre Smits This issue is a generic issue, which exists in all other places where list form is used for generating pdf. Some of the places are - 1) Approved Product Requirements Pdf (ordermgr/control/ApprovedProductRequirements) 2) Facility Inventory By Product Pdf (facility/control/ViewFacilityInventoryByProduct)
        Hide
        toashishvijay Ashish Vijaywargiya added a comment -

        Thanks Ravi for the contribution. Your changes has been committed at r1749850

        Show
        toashishvijay Ashish Vijaywargiya added a comment - Thanks Ravi for the contribution. Your changes has been committed at r1749850

          People

          • Assignee:
            toashishvijay Ashish Vijaywargiya
            Reporter:
            lodhiravi Ravi Lodhi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development