Details

      Description

      Order By Referrer is not working
      Screen : https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions
      Section : Order By Referrer

      1. OFBIZ-7318.patch
        48 kB
        Rohit Koushal

        Activity

        Hide
        rohit.koushal Rohit Koushal added a comment -

        Found out that in OrderByReferrer.rptdesign we tried to fetch nonexisting fields like "visitId" and "initialReferrer" from SalesOrderItemFact which causing problem in this report.

        Show
        rohit.koushal Rohit Koushal added a comment - Found out that in OrderByReferrer.rptdesign we tried to fetch nonexisting fields like "visitId" and "initialReferrer" from SalesOrderItemFact which causing problem in this report.
        Hide
        rohit.koushal Rohit Koushal added a comment - - edited

        On rev #886743 SalesOrderItemFact extended with visitId and initialReferrer and on rev #1055774 these field has been removed. So I think we need to clean references of visitId and initialReferrer from the report and if we removed these fields then report will not make any sense. So in my opinion it is better to remove this report from OFBIZ.

        Show
        rohit.koushal Rohit Koushal added a comment - - edited On rev #886743 SalesOrderItemFact extended with visitId and initialReferrer and on rev #1055774 these field has been removed. So I think we need to clean references of visitId and initialReferrer from the report and if we removed these fields then report will not make any sense. So in my opinion it is better to remove this report from OFBIZ.
        Hide
        rohit.koushal Rohit Koushal added a comment -

        Guys, Any suggestions on this ticket?

        Show
        rohit.koushal Rohit Koushal added a comment - Guys, Any suggestions on this ticket?
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Hi Hans Bakker, since you committed the 2 revisions referenced above, what do you think? Should we not remove this report from OFBiz?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Hi Hans Bakker , since you committed the 2 revisions referenced above, what do you think? Should we not remove this report from OFBiz?
        Hide
        pfm.smits Pierre Smits added a comment -

        Please provide a patch file if you can.

        Show
        pfm.smits Pierre Smits added a comment - Please provide a patch file if you can.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I got this answer from Hans and here is mine to him

        Thanks Hans,

        We will remove then

        Jacques

        Le 20/09/2016 à 15:58, Hans Bakker a écrit :
        >
        > Is up to you Jacques, the customer who required these reports is gone.
        >
        > Regards, Hans

        Show
        jacques.le.roux Jacques Le Roux added a comment - I got this answer from Hans and here is mine to him Thanks Hans, We will remove then Jacques Le 20/09/2016 à 15:58, Hans Bakker a écrit : > > Is up to you Jacques, the customer who required these reports is gone. > > Regards, Hans
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Please Rohit, removes the report, thanks!

        Show
        jacques.le.roux Jacques Le Roux added a comment - Please Rohit, removes the report, thanks!
        Hide
        rohit.koushal Rohit Koushal added a comment - - edited

        Thanks Pierre Smits and Jacques Le Roux for getting involved. Here is the patch that removes Order By Referrer report from the trunk.

        Please remove below data from existing database to avoid any data related problem.

            <PortalPortlet portalPortletId="OrderByReferrer"
                           portletName="Sale Orders By Referrer Report"
                           screenName="SaleOrdersByReferrerReport"
                           screenLocation="component://birt/widget/order/OrderScreens.xml"
                           description=""/>
            <PortletPortletCategory portalPortletId="OrderByReferrer" portletCategoryId="REPORT"/>
            <PortalPagePortlet portalPageId="OrderReportPage" portalPortletId="OrderByReferrer" portletSeqId="00001" columnSeqId="00001" sequenceNum="5"/>
        
        Show
        rohit.koushal Rohit Koushal added a comment - - edited Thanks Pierre Smits and Jacques Le Roux for getting involved. Here is the patch that removes Order By Referrer report from the trunk. Please remove below data from existing database to avoid any data related problem. <PortalPortlet portalPortletId= "OrderByReferrer" portletName= "Sale Orders By Referrer Report" screenName= "SaleOrdersByReferrerReport" screenLocation= "component: //birt/widget/order/OrderScreens.xml" description=""/> <PortletPortletCategory portalPortletId= "OrderByReferrer" portletCategoryId= "REPORT" /> <PortalPagePortlet portalPageId= "OrderReportPage" portalPortletId= "OrderByReferrer" portletSeqId= "00001" columnSeqId= "00001" sequenceNum= "5" />
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Rohit,

        Your patch is in
        trunk r1761678
        R15.12 r1761680
        R14.12 r1761671

        R13.07 not backported, too hard tree conflicts

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Rohit, Your patch is in trunk r1761678 R15.12 r1761680 R14.12 r1761671 R13.07 not backported, too hard tree conflicts

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            rohit.koushal Rohit Koushal
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development