Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7311

Formatting and renaming of the CSS files as per best practices

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: themes
    • Labels:
      None
    • Sprint:
      Community Day 2 - 2016

      Description

      In CSS files, we are having various inconsistency in the formatting of the code for e.g. we have following types of code formatting

      // No space

      ul#preferences-menu a:hover {
      text-decoration: none;
      }
      

      // Space of 2

      div.autocomplete ul {
        list-style-type:none;
        margin:0;
        padding:0;
      }
      

      // Space of 4

      .control-area a {
          font-size: 1.1em;
          color: #5CA3D7;
      }
      

      For better readability we should format the existing files with space of 4.

      Also for some theme, we named CSS files as maincss.css and for some, we named it as style.css. We can rename these file as per best practices for consistency.

        Attachments

        1. OFBIZ-7311-removed_references_of_maincss.patch
          37 kB
          Swapnil M Mane
        2. OFBIZ-7311-renamed-maincss-to-style.patch
          14 kB
          Swapnil M Mane
        3. OFBIZ-7311-tomahawk.patch
          176 kB
          Swapnil M Mane
        4. OFBIZ-7311-rainbowstone.patch
          97 kB
          Swapnil M Mane
        5. OFBIZ-7311-multiflex.patch
          136 kB
          Swapnil M Mane
        6. OFBIZ-7311-flatgrey.patch
          152 kB
          Swapnil M Mane
        7. OFBIZ-7311-droppingcrumbs.patch
          144 kB
          Swapnil M Mane
        8. OFBIZ-7311-bluelight.patch
          118 kB
          Swapnil M Mane
        9. OFBIZ-7311-bizznesstime.patch
          145 kB
          Swapnil M Mane

          Activity

            People

            • Assignee:
              pandeypranay Pranay Pandey
              Reporter:
              swapnilmmane Swapnil M Mane
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: