Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7297

Migrate promotext.properties to UiLabels

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: product
    • Labels:
      None

      Description

      promotext.properties file is used only in ProductPromoWorker.makeAutoDescription() method and was implemented way back when UI Labels were managed in *.properties files. It should be moved to UiLabels file because all the properties defined in the file are text descriptions and not system configurations, which makes them a candidate of internationalization.

      1. OFBIZ-7297.patch
        12 kB
        Suraj Khurana
      2. OFBIZ-7297-2.patch
        16 kB
        Suraj Khurana

        Activity

        Hide
        suraj.khurana Suraj Khurana added a comment -

        Added patch with proper fix.

        Show
        suraj.khurana Suraj Khurana added a comment - Added patch with proper fix.
        Hide
        mridul.pathak Mridul Pathak added a comment -

        Thanks Suraj for your contribution. Your patch in trunk r1751424 and r1751427.

        I am not closing this ticket as we still need to migrate promotext_zh.properties and promotext_zh_TW.properties.

        Show
        mridul.pathak Mridul Pathak added a comment - Thanks Suraj for your contribution. Your patch in trunk r1751424 and r1751427. I am not closing this ticket as we still need to migrate promotext_zh.properties and promotext_zh_TW.properties.
        Hide
        suraj.khurana Suraj Khurana added a comment -

        Thanks Mridul Pathak. Added another patch with required changes, deleted old files as well. I will be creating another ticket for such type of old property driven UiLabel files.

        Show
        suraj.khurana Suraj Khurana added a comment - Thanks Mridul Pathak . Added another patch with required changes, deleted old files as well. I will be creating another ticket for such type of old property driven UiLabel files.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        There is a small issue with this commit: ProductPromoOperatorEquality.PPC_EQ is used for 2 different labels, same for ProductPromoCondition.PPIP_PARTY_GRP_MEM

        Show
        jacques.le.roux Jacques Le Roux added a comment - There is a small issue with this commit: ProductPromoOperatorEquality.PPC_EQ is used for 2 different labels, same for ProductPromoCondition.PPIP_PARTY_GRP_MEM
        Hide
        mridul.pathak Mridul Pathak added a comment -

        Thanks Suraj Khurana, your second patch is in trunk r1754595 with modifications to include corrections suggested by Jacques Le Roux.

        Show
        mridul.pathak Mridul Pathak added a comment - Thanks Suraj Khurana , your second patch is in trunk r1754595 with modifications to include corrections suggested by Jacques Le Roux .
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks guys!

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks guys!

          People

          • Assignee:
            mridul.pathak Mridul Pathak
            Reporter:
            mridul.pathak Mridul Pathak
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development