Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7154

Update Survey Question is not working from the list of SurveyQuestionAppl

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: content
    • Labels:
      None

      Description

      Steps to regenerate:

      1.) Find Survey (https://localhost:8443/content/control/FindSurvey)
      2.) Open any Survey
      3.) Select the sub-menu 'Questions'
      4.) In 'Edit Survey Questions Survey ID' section, Question field is editable.
      5.) Edit the Question detail in this field.
      6.) Use the Update option in the row.
      7.) The question doesn't get updated.

      Please find the screenshot (update_question.png) for more details.

      Also, it has minor UI improvement,

      1.) Select the 'Edit Question' option in 'Edit Survey Questions Survey ID #' section
      2.) Now, in the 'Edit Question' section below, the submit button title should be 'Update' instead of 'Create'

      Please refer screenshot (ui_improvement.png) for more details.

      1. ui_improvement.png
        252 kB
        Swapnil M Mane
      2. update_question.png
        236 kB
        Swapnil M Mane
      3. OFBIZ-7154.patch
        2 kB
        Vaibhav Jain
      4. OFBIZ-7154.patch
        2 kB
        Vaibhav Jain

        Activity

        Hide
        pandeypranay Pranay Pandey added a comment -

        Thanks Swapnil M Mane and Vaibhav Jain for the contribution.

        Patch committed to trunk at r1746779.

        Show
        pandeypranay Pranay Pandey added a comment - Thanks Swapnil M Mane and Vaibhav Jain for the contribution. Patch committed to trunk at r1746779.
        Hide
        vaibhav.jain Vaibhav Jain added a comment -

        In the last patch </td> is missing by mistake. So, here is the updated patch.

        Show
        vaibhav.jain Vaibhav Jain added a comment - In the last patch </td> is missing by mistake. So, here is the updated patch.
        Hide
        vaibhav.jain Vaibhav Jain added a comment -

        Here is the patch

        Show
        vaibhav.jain Vaibhav Jain added a comment - Here is the patch
        Hide
        swapnilmmane Swapnil M Mane added a comment -

        Thanks Pranay for sharing your thoughts, sounds good suggestion to me

        This will help in making things simple, instead of confusing to the user by providing redundant options for doing the similar thing on the same page.

        Show
        swapnilmmane Swapnil M Mane added a comment - Thanks Pranay for sharing your thoughts, sounds good suggestion to me This will help in making things simple, instead of confusing to the user by providing redundant options for doing the similar thing on the same page.
        Hide
        pandeypranay Pranay Pandey added a comment -

        Hi Swapnil M Mane,
        Thanks for reporting the issue.

        IMO in the list of SurveyQuestionAppl, question field has to be read-only and user shouldn't be allowed to update it from there, as Edit Question option for each list item is given separately and can be used to update the specific question description and question itself.

        WDYT?

        Show
        pandeypranay Pranay Pandey added a comment - Hi Swapnil M Mane , Thanks for reporting the issue. IMO in the list of SurveyQuestionAppl, question field has to be read-only and user shouldn't be allowed to update it from there, as Edit Question option for each list item is given separately and can be used to update the specific question description and question itself. WDYT?

          People

          • Assignee:
            pandeypranay Pranay Pandey
            Reporter:
            swapnilmmane Swapnil M Mane
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development