Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: cmssite
    • Labels:
      None

      Description

      While referring specialpurpose cmssite component I found it not working.

      After trying many combinations of URLs I picked from CmsSiteDemoData.xml, it's always returning cmsSite : 404 Not Found. Please refer attached screenshots.

      Urls I tried:
      http://localhost:8080/cmssite/cms/CMSS_DEMO_PAGE1
      http://localhost:8080/cmssite/cms/CMSS_PPOINT/demoPage1
      http://localhost:8080/cmssite/cms/CMSS_DEMO_SCREEN

      I will look into the issue and provide the patch for the same.

      1. CMSS_DEMO_PAGE1.png
        60 kB
        Pranay Pandey
      2. CMSS_DEMO_SCREEN.png
        62 kB
        Pranay Pandey
      3. demoPage1.png
        61 kB
        Pranay Pandey

        Issue Links

          Activity

          Hide
          deepak.dixit Deepak Dixit added a comment -

          Hi Pranay,

          Could you please check it with fresh data load?
          I am able to run mentioned url with fresh data load on 15.12.

          Show
          deepak.dixit Deepak Dixit added a comment - Hi Pranay, Could you please check it with fresh data load? I am able to run mentioned url with fresh data load on 15.12.
          Hide
          deepak.dixit Deepak Dixit added a comment -

          I think this issue was introduced at r#1635232 and fixed at r#1643061, Here is the reference ticket id OFBIZ-5896

          Show
          deepak.dixit Deepak Dixit added a comment - I think this issue was introduced at r#1635232 and fixed at r#1643061, Here is the reference ticket id OFBIZ-5896
          Hide
          pandeypranay Pranay Pandey added a comment -

          Hi Deepak,

          Thanks for looking into it and providing comment. I checked it again and found in Trunk only, working fine on 15.12 and 14.12 releases.

          Show
          pandeypranay Pranay Pandey added a comment - Hi Deepak, Thanks for looking into it and providing comment. I checked it again and found in Trunk only, working fine on 15.12 and 14.12 releases.
          Hide
          pandeypranay Pranay Pandey added a comment -

          It actually still exists in Trunk.

          Show
          pandeypranay Pranay Pandey added a comment - It actually still exists in Trunk.
          Hide
          pandeypranay Pranay Pandey added a comment -

          Hi Deepak,

          Here is the code block from Trunk from CmsEvents class which is uncommented in R15.12 and allowing the current setup to work:

          // get the contentId/mapKey from URL
                      /* We use path aliases for everything anyway, so don't interpret the pathInfo as contentId.
                       * This makes 404 pages much faster.
                      if (contentId == null) {
                          if (Debug.verboseOn()) Debug.logVerbose("Current PathInfo: " + pathInfo, module);
                          String[] pathSplit = pathInfo.split("/");
                          if (Debug.verboseOn()) Debug.logVerbose("Split pathinfo: " + pathSplit.length, module);
                          contentId = pathSplit[0];
                          if (pathSplit.length > 1) {
                              mapKey = pathSplit[1];
                          }
                      }
                      */
          

          With current setup in Trunk we'll need to add PathAliases to all the pages to make them work. Please let me know your thoughts on it.

          Show
          pandeypranay Pranay Pandey added a comment - Hi Deepak, Here is the code block from Trunk from CmsEvents class which is uncommented in R15.12 and allowing the current setup to work: // get the contentId/mapKey from URL /* We use path aliases for everything anyway, so don't interpret the pathInfo as contentId. * This makes 404 pages much faster. if (contentId == null ) { if (Debug.verboseOn()) Debug.logVerbose( "Current PathInfo: " + pathInfo, module); String [] pathSplit = pathInfo.split( "/" ); if (Debug.verboseOn()) Debug.logVerbose( "Split pathinfo: " + pathSplit.length, module); contentId = pathSplit[0]; if (pathSplit.length > 1) { mapKey = pathSplit[1]; } } */ With current setup in Trunk we'll need to add PathAliases to all the pages to make them work. Please let me know your thoughts on it.
          Hide
          deepak.dixit Deepak Dixit added a comment -

          Thanks Pranay.

          I think we have to uncomment this section. We can render content using ContentId or mapKey or pathAlise.
          As this block commented then we are forced to use only webSitePath alise to render content.

          This code has been committed under OFBIZ-4502, Jacques Le Roux can add more on this.

          Show
          deepak.dixit Deepak Dixit added a comment - Thanks Pranay. I think we have to uncomment this section. We can render content using ContentId or mapKey or pathAlise. As this block commented then we are forced to use only webSitePath alise to render content. This code has been committed under OFBIZ-4502 , Jacques Le Roux can add more on this.
          Hide
          pandeypranay Pranay Pandey added a comment -

          Thanks Deepak, let's wait for Jacques comment on this. I will say +1 to uncommenting this block in trunk.

          Show
          pandeypranay Pranay Pandey added a comment - Thanks Deepak, let's wait for Jacques comment on this. I will say +1 to uncommenting this block in trunk.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          I already uncommented out blocks (commented out in the patch) while committing. It this fixes it and have not side effects I'm all for. And we don't care much about "404 pages much faster." Anyway if people prefer them fast it's now possible by using pathalias if I understand well... So +1

          Show
          jacques.le.roux Jacques Le Roux added a comment - I already uncommented out blocks (commented out in the patch) while committing. It this fixes it and have not side effects I'm all for. And we don't care much about "404 pages much faster." Anyway if people prefer them fast it's now possible by using pathalias if I understand well... So +1
          Hide
          pandeypranay Pranay Pandey added a comment -

          Thanks for confirmation Jacques, I will take care of uncommenting the code in trunk.

          Show
          pandeypranay Pranay Pandey added a comment - Thanks for confirmation Jacques, I will take care of uncommenting the code in trunk.
          Hide
          pandeypranay Pranay Pandey added a comment -

          Thanks Deepak Dixit and Jacques Le Roux for comments and help.

          Uncommented code in the trunk at revision 1745569.

          We can definitely add in samples for usage of WebSitePathAlias but that's an improvement and can be covered in other task, closing this ticket.

          Show
          pandeypranay Pranay Pandey added a comment - Thanks Deepak Dixit and Jacques Le Roux for comments and help. Uncommented code in the trunk at revision 1745569. We can definitely add in samples for usage of WebSitePathAlias but that's an improvement and can be covered in other task, closing this ticket.
          Hide
          pandeypranay Pranay Pandey added a comment -

          Added an improvement ticket for data update OFBIZ-7132.

          Show
          pandeypranay Pranay Pandey added a comment - Added an improvement ticket for data update OFBIZ-7132 .
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks Pranay!

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks Pranay!

            People

            • Assignee:
              pandeypranay Pranay Pandey
              Reporter:
              pandeypranay Pranay Pandey
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development