Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7102

Fix the Approve button label for newly added item to the existing PO

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 16.11.01
    • Component/s: order
    • Labels:
      None

      Description

      Upon Adding new item to existing approved purchase order creates a new line item to the existing order in CREATED state but it shows the button label as 'APPROVE ORDER' instead of 'APPROVE ITEM'.

      Please refer to attached screenshot for more details

      1. ApproveButtonLabel.png
        66 kB
        Ratnesh Upadhyay
      2. OFBIZ-7102-trunk.patch
        2 kB
        Mohammad Kathawala

        Activity

        Hide
        diveshdut Divesh Dutta added a comment -

        Thanks Ratnesh Upadhyay for reporting the issue and thanks Mohammad Kathawala for providing the patch. Your patch is committed in revision 1744948 in trunk.

        Show
        diveshdut Divesh Dutta added a comment - Thanks Ratnesh Upadhyay for reporting the issue and thanks Mohammad Kathawala for providing the patch. Your patch is committed in revision 1744948 in trunk.
        Hide
        Mohammad K Mohammad Kathawala added a comment -

        Changed the Button Label to 'Approve Item'

        Show
        Mohammad K Mohammad Kathawala added a comment - Changed the Button Label to 'Approve Item'
        Hide
        upadhyay.ratnesh Ratnesh Upadhyay added a comment -

        Pierre, there is no functional changes required to fix this issue. UI label needs to be change from "Approve Order" to "Approve Item" which is misleading the user.

        Show
        upadhyay.ratnesh Ratnesh Upadhyay added a comment - Pierre, there is no functional changes required to fix this issue. UI label needs to be change from "Approve Order" to "Approve Item" which is misleading the user.
        Hide
        pfm.smits Pierre Smits added a comment -

        Is this the behaviour we want to have for orders approved? Have we considered the effect on forecasts, payments, accounting transactions, etc?

        Show
        pfm.smits Pierre Smits added a comment - Is this the behaviour we want to have for orders approved? Have we considered the effect on forecasts, payments, accounting transactions, etc?

          People

          • Assignee:
            diveshdut Divesh Dutta
            Reporter:
            upadhyay.ratnesh Ratnesh Upadhyay
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development