Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7091

Two empty options are shown in shipping method select box on Edit promo screen

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: product
    • Labels:
      None

      Description

      On Edit promo screen, in existing condition section's select box two empty options are shown.
      Please find the screenshot for more detail.

      Reason and Solution:
      As per the code in EditProductPromoRules.ftl,

      <option value = "${carrierShippingMethod!}">${carrierParty!}&nbsp;${description}</option
      <option value = "">&nbsp;</option>
      

      And the carrierParty is calculated above, if it is not available the first option will show automatically as empty option

      <option value = "${carrierShippingMethod!}">${carrierParty!}&nbsp;${description}</option>
      

      So, we don't need the second empty option field and can remove it.

      <option value = "">&nbsp;</option>
      

        Attachments

        1. EditProductPromoRules.png
          266 kB
          Swapnil M Mane
        2. OFBIZ-7091.patch
          1.0 kB
          Swapnil M Mane
        3. OFBIZ-7091.patch
          1.0 kB
          Swapnil M Mane

          Activity

            People

            • Assignee:
              pandeypranay Pranay Pandey
              Reporter:
              swapnilmmane Swapnil M Mane
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: