Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7029

Continue the work on the form widget grid element

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: framework
    • Labels:
      None

      Description

      Last year Adrian introduced the grid element to replace the form list type. This began in 2010 with a discussion started by Scott and continued with this conversation

      Unfortunately Adrian did not get a chance to complete his work.

      There is few that can be easily done before really continuing the task Adrian started:

      • Update the XSD documentation
      • remove the list type when the grid element is used
      • replace the form lists by grids

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Started at 1741866 , 2 1st points done

        Show
        jacques.le.roux Jacques Le Roux added a comment - Started at 1741866 , 2 1st points done
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        At r1741873. I Replaced few form lists by grids, where it was possible to do it with regexp. For a reason I still don't understand I could not do it for all...

        BTW I used
        <form(.*) type="list" to find and <form$1 then to replace for the 1st line
        For the last line
        <grid((.|\n)*?)</form>and <grid$1</grid>

        Show
        jacques.le.roux Jacques Le Roux added a comment - At r1741873. I Replaced few form lists by grids, where it was possible to do it with regexp. For a reason I still don't understand I could not do it for all... BTW I used <form(.*) type="list" to find and <form$1 then to replace for the 1st line For the last line <grid((.|\n)*?)</form>and <grid$1</grid>
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        About that, I wonder if the work done by Adrian to autocorrect minilang could not be reused here. I mean this: autocorrect=false.

        Show
        jacques.le.roux Jacques Le Roux added a comment - About that, I wonder if the work done by Adrian to autocorrect minilang could not be reused here. I mean this: autocorrect=false.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I found a bug when getting to webtools/control/FindUtilCache. I will try to debug the grid stuff before reverting the whole commit :/

        Show
        jacques.le.roux Jacques Le Roux added a comment - I found a bug when getting to webtools/control/FindUtilCache. I will try to debug the grid stuff before reverting the whole commit :/
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        I created OFBIZ-7033 for that. BTW here is the comment Adrian lefts with r1654670 early 2015

        First pass at extracting grid widget from the form widget. This commit has a lot of duplicate code - future commits will reduce and reuse the duplicate code.

        Since then he did not touch the stuff much it seems...

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited I created OFBIZ-7033 for that. BTW here is the comment Adrian lefts with r1654670 early 2015 First pass at extracting grid widget from the form widget. This commit has a lot of duplicate code - future commits will reduce and reuse the duplicate code. Since then he did not touch the stuff much it seems...
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        OK I consider the experience is enough for me. I stop there!

        Show
        jacques.le.roux Jacques Le Roux added a comment - OK I consider the experience is enough for me. I stop there!
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        There are bad days, this is one. I committed too much changes (included pending ones) at r1742196 so I had to revert the not wanted part at r1742197
        Moreover for a reason I ignore, (I guess some formatting issues) some files committed at r1742196 contained a lot of false changes (ie no real changes).

        Show
        jacques.le.roux Jacques Le Roux added a comment - There are bad days, this is one. I committed too much changes (included pending ones) at r1742196 so I had to revert the not wanted part at r1742197 Moreover for a reason I ignore, (I guess some formatting issues) some files committed at r1742196 contained a lot of false changes (ie no real changes).
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Also,
        r1742198 removes a file committed by error, and
        r1742198 moves the FindFixedAssetOptions form back to its original position

        Show
        jacques.le.roux Jacques Le Roux added a comment - Also, r1742198 removes a file committed by error, and r1742198 moves the FindFixedAssetOptions form back to its original position

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            jacques.le.roux Jacques Le Roux
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development