Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7008

Support to add condition for Geo Location in Promo Engine

        Details

        • Type: New Feature
        • Status: Closed
        • Priority: Trivial
        • Resolution: Fixed
        • Affects Version/s: Trunk
        • Fix Version/s: 16.11.01
        • Component/s: None
        • Labels:
          None
        1. Text File
          OFBIZ-7008.patch
          10 kB
          Vishal Chhabria
        2. Text File
          OFBIZ-7008.patch
          10 kB
          Vishal Chhabria
        3. Text File
          OFBIZ-7008.patch
          10 kB
          Vishal Chhabria
        4. Text File
          OFBIZ-7008.patch
          3 kB
          Vishal Chhabria
        5. XML File
          SampleData.xml
          0.9 kB
          Vishal Chhabria

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          vishal.chhabria Vishal Chhabria added a comment -

          Attached patch for the feature.

          Show
          vishal.chhabria Vishal Chhabria added a comment - Attached patch for the feature.
          Hide
          Permalink
          vishal.chhabria Vishal Chhabria added a comment -

          Working on sample data for this feature. I will attach the sample data and provide steps to test it.

          Show
          vishal.chhabria Vishal Chhabria added a comment - Working on sample data for this feature. I will attach the sample data and provide steps to test it.
          Hide
          Permalink
          vishal.chhabria Vishal Chhabria added a comment -

          Attached sample data for promotion 'Free Shipping in Utah state'.

          Show
          vishal.chhabria Vishal Chhabria added a comment - Attached sample data for promotion 'Free Shipping in Utah state'.
          Hide
          Permalink
          vishal.chhabria Vishal Chhabria added a comment -

          Attached the updated patch with demo data. Also, made some improvements in code.

          Steps to test -
          For Promotion "Free Shipping in Utah state".

          1) Upload sample data attached with the ticket.
          2) Add items to cart either form ecommerce or ordermgr.
          3) In the check process select/add shipping address with state as UT.

          Discount should be applied with amount equal to shipping cost.

          Show
          vishal.chhabria Vishal Chhabria added a comment - Attached the updated patch with demo data. Also, made some improvements in code. Steps to test - For Promotion "Free Shipping in Utah state". 1) Upload sample data attached with the ticket. 2) Add items to cart either form ecommerce or ordermgr. 3) In the check process select/add shipping address with state as UT. Discount should be applied with amount equal to shipping cost.
          Hide
          Permalink
          mridul.pathak Mridul Pathak added a comment -

          Thanks Vishal for contribution. Your patch is in trunk r1739457.

          Show
          mridul.pathak Mridul Pathak added a comment - Thanks Vishal for contribution. Your patch is in trunk r1739457.
          Hide
          Permalink
          jacques.le.roux Jacques Le Roux added a comment - - edited

          Hi Mridul,

          Please revert or fix, tests don't pass since: https://ci.apache.org/builders/ofbiz-trunk

          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited Hi Mridul, Please revert or fix, tests don't pass since: https://ci.apache.org/builders/ofbiz-trunk
          Hide
          Permalink
          jacques.le.roux Jacques Le Roux added a comment -

          Also https://ci.apache.org/projects/ofbiz/logs/trunk/html/

          Show
          jacques.le.roux Jacques Le Roux added a comment - Also https://ci.apache.org/projects/ofbiz/logs/trunk/html/
          Hide
          Permalink
          mridul.pathak Mridul Pathak added a comment -

          Thanks Jacques for reporting, reverted in r1739637.

          Show
          mridul.pathak Mridul Pathak added a comment - Thanks Jacques for reporting, reverted in r1739637.
          Hide
          Permalink
          mridul.pathak Mridul Pathak added a comment -

          Hi Vishal,
          Would you be fixing the tests and provide the updated patch?

          Show
          mridul.pathak Mridul Pathak added a comment - Hi Vishal, Would you be fixing the tests and provide the updated patch?
          Hide
          Permalink
          vishal.chhabria Vishal Chhabria added a comment -

          Mridul Pathak I am on it. I will fix the tests and provide the updated patch.

          Show
          vishal.chhabria Vishal Chhabria added a comment - Mridul Pathak I am on it. I will fix the tests and provide the updated patch.
          Hide
          Permalink
          vishal.chhabria Vishal Chhabria added a comment -

          Updated patch with proper productPromoRuleId which caused the errors while loading data.

          Show
          vishal.chhabria Vishal Chhabria added a comment - Updated patch with proper productPromoRuleId which caused the errors while loading data.
          Hide
          Permalink
          mridul.pathak Mridul Pathak added a comment -

          Hi Vishal Chhabria,

          productPromoId must be lesser than 10000 as per OFBiz sequencing rules. Could you please correct that and provide an updated patch?

          Show
          mridul.pathak Mridul Pathak added a comment - Hi Vishal Chhabria , productPromoId must be lesser than 10000 as per OFBiz sequencing rules. Could you please correct that and provide an updated patch?
          Hide
          Permalink
          vishal.chhabria Vishal Chhabria added a comment -

          Updated productPromoId.

          Show
          vishal.chhabria Vishal Chhabria added a comment - Updated productPromoId.
          Hide
          Permalink
          mridul.pathak Mridul Pathak added a comment -

          Thanks for the updated patch Vishal Chhabria. Your patch is in trunk r1748186.

          Show
          mridul.pathak Mridul Pathak added a comment - Thanks for the updated patch Vishal Chhabria . Your patch is in trunk r1748186.

            People

            • Assignee:
              mridul.pathak Mridul Pathak
              Reporter:
              vishal.chhabria Vishal Chhabria
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development