Thanks for the review Gil,
is there something blocking commiting
OFBIZ-4090 ? i didn't review it in details...
Yes there were some issues, it was not really complete. At revision: 1738958 I put in trunk all
OFBIZ-4090 and OFBIZ-6990 changes refactored and I will close OFBIZ-4090 with OFBIZ-6990. I think we could do a better example, but that would be another Jira!
Here are the changes globally
- As James mentionned we no longer need *-v2.xsd files, I removed them from Adrian's patch
- I created a compound-widgets.xsd based on Adrian's and James Yong's previous work. From Paul Foxworthy's comment in
OFBIZ-4090, I decided to name the root compound-widgets (hence the file name). I arranged its elements in another way, see below with ExampleCompoundWidgets.xml
- I slightly modified James Yong's ExampleCompoundScreenWidget.xml file and renamed it ExampleCompoundWidgets.xml. I added an "s" because there are several OFBiz widgets gathered in one place. For the modifications: I simply changed the names and arranged the elements in another way which I find better suited. I'm used to 1st create the query, then the menus, the screens and their forms. We rarely use widget-trees but it's there also. Finally the simple-method at end if any. The order is not enforced though, so everybody can use her/his own
- I added a French label
- I completed the widget-catalog.xml with this new entry and tested locally in Eclipse by reloading the XML catalog entries.