Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6938

Move forms in ProductStoreForms.xml to StoreForms.xml

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: product
    • Labels:
      None
    1. OFBiz-6936-StoreForms-v2.patch
      53 kB
      Pierre Smits
    2. OFBIZ-6938-StoreForms.patch
      166 kB
      Pierre Smits

      Activity

      Hide
      jacques.le.roux Jacques Le Roux added a comment -

      We checked with Pierre, it's definitely OK

      Show
      jacques.le.roux Jacques Le Roux added a comment - We checked with Pierre, it's definitely OK
      Hide
      jacques.le.roux Jacques Le Roux added a comment -

      I simply added the necessary changes in StoreScreens.xml and removed ProductStoreForms.xml. I did not test yet because I have an issue with CatalinaContainer.java, should be OK, the changes are straightforward

      Show
      jacques.le.roux Jacques Le Roux added a comment - I simply added the necessary changes in StoreScreens.xml and removed ProductStoreForms.xml. I did not test yet because I have an issue with CatalinaContainer.java, should be OK, the changes are straightforward
      Hide
      jacques.le.roux Jacques Le Roux added a comment -

      Done at revision: 1735844

      Show
      jacques.le.roux Jacques Le Roux added a comment - Done at revision: 1735844
      Hide
      pfm.smits Pierre Smits added a comment -

      Ahh. Ok. Thanks for the update. I'll see what I can do.

      Show
      pfm.smits Pierre Smits added a comment - Ahh. Ok. Thanks for the update. I'll see what I can do.
      Hide
      jacques.le.roux Jacques Le Roux added a comment -

      Yes sorry, was quite late. It seems you missed to add the changes you 1st put in StoreScreens.xml and I can't reuse what you did since it does not apply

      Show
      jacques.le.roux Jacques Le Roux added a comment - Yes sorry, was quite late. It seems you missed to add the changes you 1st put in StoreScreens.xml and I can't reuse what you did since it does not apply
      Hide
      pfm.smits Pierre Smits added a comment -

      Thanks, Jacques Le Roux., for the cryptic reaction.

      Show
      pfm.smits Pierre Smits added a comment - Thanks, Jacques Le Roux ., for the cryptic reaction.
      Hide
      jacques.le.roux Jacques Le Roux added a comment -

      Hi Pierre,

      Seems you missed some parts...

      Show
      jacques.le.roux Jacques Le Roux added a comment - Hi Pierre, Seems you missed some parts...
      Hide
      pfm.smits Pierre Smits added a comment -

      This patch addresses the issue raised by Jacques Le Roux

      Show
      pfm.smits Pierre Smits added a comment - This patch addresses the issue raised by Jacques Le Roux
      Hide
      jacques.le.roux Jacques Le Roux added a comment -

      Sorry Pierre,

      Your patch does not apply completly could you please update your working copy and create it again? Thanks!

      Show
      jacques.le.roux Jacques Le Roux added a comment - Sorry Pierre, Your patch does not apply completly could you please update your working copy and create it again? Thanks!
      Hide
      pfm.smits Pierre Smits added a comment -

      This patch addresses the issue.

      Show
      pfm.smits Pierre Smits added a comment - This patch addresses the issue.

        People

        • Assignee:
          jacques.le.roux Jacques Le Roux
          Reporter:
          pfm.smits Pierre Smits
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development