Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: ALL COMPONENTS, framework
    • Labels:
      None

      Description

      Add a new renderer type in order to enable XLS file output.

      1. xls-renderer.patch
        29 kB
        Leila Mekika
      2. Sélection_154.png
        53 kB
        Nicolas Malin
      3. OFBIZ-6931.patch
        32 kB
        Nicolas Malin
      4. OFBIZ-6931.patch
        32 kB
        Nicolas Malin

        Issue Links

          Activity

          Hide
          soledad Nicolas Malin added a comment -

          Ok It's commited at revision 1746045 on trunk

          Show
          soledad Nicolas Malin added a comment - Ok It's commited at revision 1746045 on trunk
          Hide
          soledad Nicolas Malin added a comment -

          I updated the patch the last remark and the refactor work realise by Deepak

          If no other suggest I will commit

          Show
          soledad Nicolas Malin added a comment - I updated the patch the last remark and the refactor work realise by Deepak If no other suggest I will commit
          Hide
          soledad Nicolas Malin added a comment -

          This call directly the standard message :

          <property key="FormFieldTitle_searchButton">
          <value xml:lang="ar">البحث</value>
          <value xml:lang="cs">Vyhledat</value>
          <value xml:lang="de">Suchen</value>
          <value xml:lang="en">Search</value>
          <value xml:lang="es">Buscar</value>
          <value xml:lang="fr">Chercher</value>
          <value xml:lang="hi-IN">खोजे</value>
          <value xml:lang="it">Ricerca</value>
          <value xml:lang="ja">検索</value>
          <value xml:lang="nl">Zoek</value>
          <value xml:lang="pt">Procurar</value>
          <value xml:lang="pt-BR">Pesquisar</value>
          <value xml:lang="ro">Cauta</value>
          <value xml:lang="ru">Искать</value>
          <value xml:lang="th">ค้นหา</value>
          <value xml:lang="vi">Tìm kiếm</value>
          <value xml:lang="zh">搜索</value>
          <value xml:lang="zh-TW">搜尋</value>
          </property>

          And I think we can also remove position="1"

          Show
          soledad Nicolas Malin added a comment - This call directly the standard message : <property key="FormFieldTitle_searchButton"> <value xml:lang="ar">البحث</value> <value xml:lang="cs">Vyhledat</value> <value xml:lang="de">Suchen</value> <value xml:lang="en">Search</value> <value xml:lang="es">Buscar</value> <value xml:lang="fr">Chercher</value> <value xml:lang="hi-IN">खोजे</value> <value xml:lang="it">Ricerca</value> <value xml:lang="ja">検索</value> <value xml:lang="nl">Zoek</value> <value xml:lang="pt">Procurar</value> <value xml:lang="pt-BR">Pesquisar</value> <value xml:lang="ro">Cauta</value> <value xml:lang="ru">Искать</value> <value xml:lang="th">ค้นหา</value> <value xml:lang="vi">Tìm kiếm</value> <value xml:lang="zh">搜索</value> <value xml:lang="zh-TW">搜尋</value> </property> And I think we can also remove position="1"
          Hide
          pfm.smits Pierre Smits added a comment -

          Is this removing of the title and the widget-style not a degradation?

          -        <field name="searchButton" title="${uiLabelMap.CommonFind}" widget-style="smallSubmit"><submit button-type="button" image-location="/images
          /icons/magnifier.png"/></field>
          

          has been replaced by

          +        <field name="searchButton" position="1"><submit/></field>
          
          Show
          pfm.smits Pierre Smits added a comment - Is this removing of the title and the widget-style not a degradation? - <field name= "searchButton" title= "${uiLabelMap.CommonFind}" widget-style= "smallSubmit" ><submit button-type= "button" image-location="/images /icons/magnifier.png"/></field> has been replaced by + <field name= "searchButton" position= "1" ><submit/></field>
          Hide
          soledad Nicolas Malin added a comment -

          + <field name="searchButton" position="1"><submit/></field>
          ?
          I'm not against, just wondering because maybe we could harmonize everywhere?

          Yes you right Jacques, maybe I change it when I view the code. If we set an image here with hard link we can't surcharge it by the theme.

          Why not rather?
          <value xml:lang="en">View as spreadsheet</value>

          No pb with it !

          Show
          soledad Nicolas Malin added a comment - + <field name="searchButton" position="1"><submit/></field> ? I'm not against, just wondering because maybe we could harmonize everywhere? Yes you right Jacques, maybe I change it when I view the code. If we set an image here with hard link we can't surcharge it by the theme. Why not rather? <value xml:lang="en">View as spreadsheet</value> No pb with it !
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          I did not review all details, nice piece of code at 1st glance.

          A small question: is it on purpose that

          -        <field name="searchButton" title="${uiLabelMap.CommonFind}" widget-style="smallSubmit"><submit button-type="button" image-location="/images
          /icons/magnifier.png"/></field>
          

          has been replaced by

          +        <field name="searchButton" position="1"><submit/></field>
          

          ?
          I'm not against, just wondering because maybe we could harmonize everywhere?

          For

          <value xml:lang="en">View as spread</value>
          

          Why not rather?

          <value xml:lang="en">View as spreadsheet</value>
          

          Not sure why, I did not see the corresponding button

              <link target="ExampleReportXls" text="${uiLabelMap.CommonViewAsXls}" style="buttontext">
                  <parameter param-name="exampleId"/>
              </link>
          

          But I must say it's late, so I did not dig further

          Show
          jacques.le.roux Jacques Le Roux added a comment - I did not review all details, nice piece of code at 1st glance. A small question: is it on purpose that - <field name= "searchButton" title= "${uiLabelMap.CommonFind}" widget-style= "smallSubmit" ><submit button-type= "button" image-location="/images /icons/magnifier.png"/></field> has been replaced by + <field name= "searchButton" position= "1" ><submit/></field> ? I'm not against, just wondering because maybe we could harmonize everywhere? For <value xml:lang= "en" >View as spread</value> Why not rather? <value xml:lang= "en" >View as spreadsheet</value> Not sure why, I did not see the corresponding button <link target= "ExampleReportXls" text= "${uiLabelMap.CommonViewAsXls}" style= "buttontext" > <parameter param-name= "exampleId" /> </link> But I must say it's late, so I did not dig further
          Hide
          soledad Nicolas Malin added a comment -

          Leila,

          I reviewed this patch and complete it with :

          • compress the class name to down the file size
          • add a link export on example search to give the possibility to convert the list result screen on xls export.

          It's nice first version, and if there are no remarks I will commit it on trunk

          Show
          soledad Nicolas Malin added a comment - Leila, I reviewed this patch and complete it with : compress the class name to down the file size add a link export on example search to give the possibility to convert the list result screen on xls export. It's nice first version, and if there are no remarks I will commit it on trunk

            People

            • Assignee:
              soledad Nicolas Malin
              Reporter:
              mleila Leila Mekika
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development