Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 14.12.01, 16.11.01
    • Component/s: marketing
    • Labels:
      None

      Description

      Error occur when create Lead/Contact from Vcard.
      This patch will improve importVcard service to able to create Lead/Contact from Vcard and display error messages when Vcard has invalid values.

      1. improtVcard.patch
        8 kB
        Chula Lathong

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Chula,

        Your slightly modified patch is in,
        trunk r1724763
        R15.12 r1724768
        R14.12 r1724769

        Older releases would need manual changes to be backported

        I simply changed the importVCard service transaction-timeout from 72000 (20 hours!) to 7200. Also added corresponding French labels

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Chula, Your slightly modified patch is in, trunk r1724763 R15.12 r1724768 R14.12 r1724769 Older releases would need manual changes to be backported I simply changed the importVCard service transaction-timeout from 72000 (20 hours!) to 7200. Also added corresponding French labels
        Hide
        lathongChu Chula Lathong added a comment -

        Improve patch for Jacques Le Roux comment

        • Remove unnecessary code.
        Show
        lathongChu Chula Lathong added a comment - Improve patch for Jacques Le Roux comment Remove unnecessary code.
        Hide
        lathongChu Chula Lathong added a comment -

        Thank you for your review Jacques Le Roux.
        1. Why did you put a transaction-timeout="72000" to importVCard service?

        • Because, Vcard which has many people cannot run with default transaction-timeout.
          2. Why did you set unmarshaller.setStrict(false); in VCard class.
        • Because, if "Strict" is "true" service will stop immediately if vcard has problem like some require field missing. So, I set "strict" to "false" to make service continues working to check and return problem of vcard data to user.
          3. Why did you "comments" when retrieving persons?
        • It was my mistake I will remove this code.
          Please let me know if your still have any question or suggestion.
          Regards.
        Show
        lathongChu Chula Lathong added a comment - Thank you for your review Jacques Le Roux. 1. Why did you put a transaction-timeout="72000" to importVCard service? Because, Vcard which has many people cannot run with default transaction-timeout. 2. Why did you set unmarshaller.setStrict(false); in VCard class. Because, if "Strict" is "true" service will stop immediately if vcard has problem like some require field missing. So, I set "strict" to "false" to make service continues working to check and return problem of vcard data to user. 3. Why did you "comments" when retrieving persons? It was my mistake I will remove this code. Please let me know if your still have any question or suggestion. Regards.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I reviewed your patch (not tested yet) and it looks good to me, I have 3 small questions though:

        1. Why did you put a transaction-timeout="72000" to importVCard service?
        2. Why did you set unmarshaller.setStrict(false); in VCard class. Quickly looking at http://jpim.sourceforge.net/api/net/wimpi/pim/contact/io/vcard/vCardUnmarshaller.html#setStrict%28boolean%29 did not help much
        3. Why did you "comments" when retrieving persons?

        Thanks!

        Show
        jacques.le.roux Jacques Le Roux added a comment - I reviewed your patch (not tested yet) and it looks good to me, I have 3 small questions though: Why did you put a transaction-timeout="72000" to importVCard service? Why did you set unmarshaller.setStrict(false); in VCard class. Quickly looking at http://jpim.sourceforge.net/api/net/wimpi/pim/contact/io/vcard/vCardUnmarshaller.html#setStrict%28boolean%29 did not help much Why did you "comments" when retrieving persons? Thanks!

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            lathongChu Chula Lathong
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development