Hi Michael

It appears that there is some seed data missing.
The below data will add a new invoice item type and map raw materials to the correct account.

<InvoiceItemType description="Invoice Raw Material(Purchase)" hasTable="N" invoiceItemTypeId="PINV_RPROD_ITEM" parentTypeId="PINV_PROD_ITEM"/>
<InvoiceItemTypeMap invoiceTypeId="PURCHASE_INVOICE" invoiceItemMapKey="RAW_MATERIAL" invoiceItemTypeId="PINV_RPROD_ITEM"/>
<InvoiceItemType invoiceItemTypeId="PINV_RPROD_ITEM" defaultGlAccountId="214000"/>

GOOD is already mapped however so that should be picking up PINV_FPROD_ITEM

This patch addresses the issue.

Thanks for your prompt action Rupert.
Will check it out tomorrow.

Sent from my Samsung Galaxy smartphone.

-------- Original message --------
From: "Rupert Howell (JIRA)" <jira@apache.org>
Date: 12/10/2015 19:30 (GMT+07:00)
To: Michael Powacht <michael.powacht@zi-th.com>
Subject: [jira] [Commented] (OFBIZ-6763) Wrong purchase invoice item type for product type IDs RAW_MATERIAL, GOOD

[ https://issues.apache.org/jira/browse/OFBIZ-6763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050910#comment-15050910 ]

Rupert Howell commented on OFBIZ-6763:
--------------------------------------

Hi Michael

It appears that there is some seed data missing.
The below data will add a new invoice item type and map raw materials to the correct account.

<InvoiceItemType description="Invoice Raw Material(Purchase)" hasTable="N" invoiceItemTypeId="PINV_RPROD_ITEM" parentTypeId="PINV_PROD_ITEM"/>
<InvoiceItemTypeMap invoiceTypeId="PURCHASE_INVOICE" invoiceItemMapKey="RAW_MATERIAL" invoiceItemTypeId="PINV_RPROD_ITEM"/>
<InvoiceItemType invoiceItemTypeId="PINV_RPROD_ITEM" defaultGlAccountId="214000"/>

GOOD is already mapped however so that should be picking up PINV_FPROD_ITEM

–
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Thansk Michael, Rupert and Pierre,

Pierre your patch is in
trunk r1719094
R14.12 r1719095
R13.07 r1719095

R12.04 was confusing, I did not backport

Thanks to all for your prompt actions, which is truly impressive! Products with product type ID "RAW_MATERIAL" work as expected now but I still face issues with products assigned to product_type_id "GOOD" where the purchase invoice still erroneously derives item type INV_FPROD_ITEM and thereby a revenue GL. I am planning to assign product_type_id GOOD to physical trading products (i.e they are not of type FINISHED_GOOD, DIGITAL_GOOD or FINDIG_GOOD)

Did I miss something?

Thanks again,
Michael

Thanks for your work Michael Powacht. As regards the type named "GOOD", it is a special type that is not supposed to be used in orders; in fact it is an "abstract" type that is parent type for several other types including physical and non physical items like "raw materials", "subassembly", "digital goods" etc..
In my opinion a better fix would be that of preventing to assign this type to a product directly: the check could be done when the product data is created/updated and when the product is added to an order (to catch wrong product data imported into the system with external tools).

Many thanks for your clarification Jacopo, I understand.

Which product type would you suggest to be assigned to regular physical products for resale?
The following product types don't classify in my opinion:
Raw Material: Used as input materials for Mfg.
Finished Good: The finished output from Mfg.
Subassembly: Semifinished ouptput from Mfg.

Assigning resale products to product type Finished Goods could lead to wrong requirements generated by MRP, i.e. internal requirements (and production runs) instead of product requirements in the form of proposed purchase orders or will that only happen if a BOM
is defined for a Finished Good Product?

Thanks,
Michael

Michael Powacht] You could create a new good type, say TGOOD (Trade Goods) with parentId=GOOD, and use that as the basis for all dependent entities related to inventory, orders, and accounting.

Sounds good Pierra, thanks!
Sorry by the way for the triple post. I was facing some internet issues earlier when replying.

No worries. It happens to all of us at times.

The (naive) mechanism currently implemented is the following: if the product has a BOM and doesn't have SupplierProduct associated then it is treated as a finished output from Mfg.

Thanks Jacopo! That's very useful information.