Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6728

Getting error when returning service (non-physical) product

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Release Branch 14.12, Trunk
    • Fix Version/s: 14.12.01, 16.11.01
    • Component/s: order
    • Labels:
      None

      Description

      I have created order with "SV-1000" product (isPhysical != 'Y' on product type entity) of SERVICE type. When I am returning this product getting error, attached (Create-Return.png & Error.png) screen-shot for the same.

      To fix above error added this data because product type of SV-1000 is SERVICE:
      ========
      <ReturnItemTypeMap returnHeaderTypeId="CUSTOMER_RETURN" returnItemMapKey="SERVICE" returnItemTypeId="RET_SPROD_ITEM"/>
      ========

      1. Create-Return.png
        121 kB
        akashjain2010
      2. Error.png
        171 kB
        akashjain2010
      3. OFBIZ-6728.patch
        1 kB
        akashjain2010

        Issue Links

          Activity

          Hide
          pfm.smits Pierre Smits added a comment -

          Are you sure that services can be returned?

          Show
          pfm.smits Pierre Smits added a comment - Are you sure that services can be returned?
          Hide
          akash.jain Akash Jain added a comment - - edited

          Attaching patch to fix reported issue.

          Show
          akash.jain Akash Jain added a comment - - edited Attaching patch to fix reported issue.
          Hide
          jacques.le.roux Jacques Le Roux added a comment - - edited

          It's only about getting the return invoice, right? I understand that that can be a problem when mixed in an order with a physical item. Can't an AGGREGATED_SERVICE be used in place?

          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited It's only about getting the return invoice, right? I understand that that can be a problem when mixed in an order with a physical item. Can't an AGGREGATED_SERVICE be used in place?
          Hide
          pfm.smits Pierre Smits added a comment -

          Is this based on the assumption that a service can be shipped?

          Show
          pfm.smits Pierre Smits added a comment - Is this based on the assumption that a service can be shipped?
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Forget this idea anyway an AGGREGATED_SERVICE can't also be returned

          Show
          jacques.le.roux Jacques Le Roux added a comment - Forget this idea anyway an AGGREGATED_SERVICE can't also be returned
          Hide
          jacopoc Jacopo Cappellato added a comment -

          Just to provide some context about this fix: this is part of the use case of refunding a service; the refund is modeled as a return of type refund. The feature of refunding a product thru a "return" without a shipment was already supported but it fails (as reported in this ticket) for non physical goods.
          I think it is a nice enhancement in line with the current features.

          Show
          jacopoc Jacopo Cappellato added a comment - Just to provide some context about this fix: this is part of the use case of refunding a service; the refund is modeled as a return of type refund. The feature of refunding a product thru a "return" without a shipment was already supported but it fails (as reported in this ticket) for non physical goods. I think it is a nice enhancement in line with the current features.
          Hide
          pfm.smits Pierre Smits added a comment - - edited

          Doing professional services is different than doing transfer of physical goods and it affects how business processes and procedures are defined (and captured in software solutions). In professional services a customer doesn't return a service, like the provider doesn't ship the service. It is more like doesn't accept/provide Or it is done partially. And that has consequences. Most probably as stated in a agreement/contract and/or general terms.

          A refund is only required when money has already exchanged hands between customer and provider. Otherwise a credit invoice suffices to counter the invoice sent. And it is the accounting department who will close the books on that.

          Show
          pfm.smits Pierre Smits added a comment - - edited Doing professional services is different than doing transfer of physical goods and it affects how business processes and procedures are defined (and captured in software solutions). In professional services a customer doesn't return a service, like the provider doesn't ship the service. It is more like doesn't accept/provide Or it is done partially. And that has consequences. Most probably as stated in a agreement/contract and/or general terms. A refund is only required when money has already exchanged hands between customer and provider. Otherwise a credit invoice suffices to counter the invoice sent. And it is the accounting department who will close the books on that.
          Hide
          jacopoc Jacopo Cappellato added a comment -

          Yes, I agree, and the use case implemented in this ticket is about:
          "A refund is only required when money has already exchanged hands between customer and provider"

          I agree with you that further work (out of scope for this ticket) is required to implement agreement based rules.

          Show
          jacopoc Jacopo Cappellato added a comment - Yes, I agree, and the use case implemented in this ticket is about: "A refund is only required when money has already exchanged hands between customer and provider" I agree with you that further work (out of scope for this ticket) is required to implement agreement based rules.
          Hide
          jacopoc Jacopo Cappellato added a comment -

          Thank you Akash, your patch is in trunk with rev. 1715485 and in branch 14.12 with rev. 1715486.

          Show
          jacopoc Jacopo Cappellato added a comment - Thank you Akash, your patch is in trunk with rev. 1715485 and in branch 14.12 with rev. 1715486.

            People

            • Assignee:
              jacopoc Jacopo Cappellato
              Reporter:
              akash.jain Akash Jain
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development