Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6705

some files set viewIndex to 1 by default rather than 0

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Patch Available
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: Trunk
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The following files set viewIndex to 1

      ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java:        if (viewIndex == null) viewIndex = 1;
      ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl:        <#--assign viewIndex = viewIndex - 1/-->
      ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex = request.getParameter("viewIndex") ? Integer.valueOf(request.getParameter("viewIndex")) : 1;
      ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex = 1;
      ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy:    viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
      ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy:            viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
      

      I ran this command to get the output:
      grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"

      As far as I am aware, viewIndex starts from 0

        Attachments

        1. OFBIZ-6705_2020.patch
          4 kB
          Michael Brohl
        2. OFBIZ-6705.patch
          10 kB
          Gareth Carter
        3. OFBIZ-6705_sample.patch
          4 kB
          Gareth Carter
        4. OFBIZ-6705.patch
          7 kB
          Gareth Carter

          Issue Links

            Activity

              People

              • Assignee:
                mbrohl Michael Brohl
                Reporter:
                gareth.carter Gareth Carter
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: