[OFBIZ-6705] some files set viewIndex to 1 by default rather than 0

• Type: Improvement
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: Trunk, Upcoming Branch
• Assignee: Michael Brohl
• Reporter: Gareth Carter
• Created: 29/Oct/15 16:18
• Updated: 11/Jan/22 08:48

Description

The following files set viewIndex to 1

./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java:        if (viewIndex == null) viewIndex = 1;
./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl:        <#--assign viewIndex = viewIndex - 1/-->
./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex = request.getParameter("viewIndex") ? Integer.valueOf(request.getParameter("viewIndex")) : 1;
./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex = 1;
./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy:    viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy:            viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);

I ran this command to get the output:
grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"

As far as I am aware, viewIndex starts from 0

Issue Links

• is depended upon by: OFBIZ-7018 Screwy page number drop-downs.