[OFBIZ-6701] Enhancement in the content wrappers

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Release Branch 11.04, Release Branch 12.04, Release Branch 13.07, Release Branch 14.12, Trunk
• Fix Version/s: 16.11.01
• Component/s: product
• Assignee: Jacques Le Roux
• Reporter: Ritu Raj Lakhera
• Created: 26/Oct/15 09:05
• Updated: 01/Feb/18 14:28
• Resolved: 07/Apr/16 15:08

Description

There are some enhancements in product content wrapper JAVA class. We used these enhancements in our project and observed good change in website performance.

1. If content of product is empty string or null then method 'getProductContentAsText' is not caching the result.
And thus every time this method is making SQL call even no content in database. Method should cache the empty string and null as result.
2. Overloaded method 'getProductContentAsText' is also using cache method of Delegator for 'ProductConetnt' entity selection and passing 'true' to use cache for 'ContentWorker.renderContentAsText' method. This approach is making unnecessary copies of cache for content.
I Product content wrapper cache
II ProductContent entity cache
III Content, Dataresource, ElectrocText and etc... entities cache(ContentWorker.renderContentAsText)

If I again call the 'getProductContentAsText' method then this will return the result from product content wrapper cache. So there is no use of ProductContent, Content, Dataresource and ElectrocText cache. And these cache also filling the memory of application.

We also applied the same logic for category content wrapper. I am attaching the patch for trunk, please review.

Issue Links

• is depended upon by: OFBIZ-6669 Possible stored XSS issue with Content
• is related to: OFBIZ-10194 ContentWrapper empty string result breaks simple FTL null check and default syntax