Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6697

CommunicationServices.createAttachmentContent duplicates attachments for existing CommunicationEvents

    Details

      Description

      When sending an email from a CommunicationEvent that exists in the database prior to calling sendMail/sendMailMultiPart, the seca updateCommEventAfterEmail will call createAttachmentContent and store any attachments into ImageDataResource and be referenced by the CommunicationEvent even if the attachments already exist in the database (and stored somewhere else).

        Activity

        Hide
        soledad Nicolas Malin added a comment -

        Ok I finished the conversion and test done on :

        • 13.07 : 1724413
        • 12.04 : 1724414
        Show
        soledad Nicolas Malin added a comment - Ok I finished the conversion and test done on : 13.07 : 1724413 12.04 : 1724414
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Great, thanks!

        Show
        jacques.le.roux Jacques Le Roux added a comment - Great, thanks!
        Hide
        soledad Nicolas Malin added a comment -

        Yes, but I didn't apply this patch. I currently try to convert it on 13.07 and 12.04.

        Show
        soledad Nicolas Malin added a comment - Yes, but I didn't apply this patch. I currently try to convert it on 13.07 and 12.04.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Older branches not concerned (did not check)?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Older branches not concerned (did not check)?
        Hide
        soledad Nicolas Malin added a comment -

        Ok, it's also fine for me

        I commited on :

        • trunk : 1724311
        • r15.12 : 1724313
        • r14.12 : 1724312

        Thanks a lot Gareth for your correction

        Show
        soledad Nicolas Malin added a comment - Ok, it's also fine for me I commited on : trunk : 1724311 r15.12 : 1724313 r14.12 : 1724312 Thanks a lot Gareth for your correction
        Hide
        lektran Scott Gray added a comment -

        Ah right sorry, I missed that it was a private method.

        Show
        lektran Scott Gray added a comment - Ah right sorry, I missed that it was a private method.
        Hide
        gareth.carter Gareth Carter added a comment -

        We have been using this patch in production for about 2 months now and have no reports of any issues. I don't personally believe it should matter about the method signature as it's private, should only deprecate public methods

        Show
        gareth.carter Gareth Carter added a comment - We have been using this patch in production for about 2 months now and have no reports of any issues. I don't personally believe it should matter about the method signature as it's private, should only deprecate public methods
        Hide
        lektran Scott Gray added a comment -

        There's no need to change the method signature since you're getting the delegator from the dispatcher anyway. And if the signature did need to change, the old should be deprecated rather than removed.

        Otherwise the patch looks fine to me, I haven't tested it though.

        Show
        lektran Scott Gray added a comment - There's no need to change the method signature since you're getting the delegator from the dispatcher anyway. And if the signature did need to change, the old should be deprecated rather than removed. Otherwise the patch looks fine to me, I haven't tested it though.

          People

          • Assignee:
            soledad Nicolas Malin
            Reporter:
            gareth.carter Gareth Carter
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development