Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6696

Remove tooltip="${uiLabelMap.CommonNotModifRecreat}" from display fields

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: ALL APPLICATIONS
    • Labels:
      None

      Description

      Many display fields have the

      tooltip="${uiLabelMap.CommonNotModifRecreat}"

      associated to a id field. But this field is only informative when the user wants to create a new record. Every other time it is superfluous.

        Activity

        Hide
        pfm.smits Pierre Smits added a comment -

        This patch addresses the issue.

        Show
        pfm.smits Pierre Smits added a comment - This patch addresses the issue.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I wonder about that. It only appear when display is used, so why this label at all then? It seems to be an information when updating to me. So I'd let it there, it's a pre Apache era stuff BTW.

        Other opinions?

        Show
        jacques.le.roux Jacques Le Roux added a comment - I wonder about that. It only appear when display is used, so why this label at all then? It seems to be an information when updating to me. So I'd let it there, it's a pre Apache era stuff BTW. Other opinions?
        Hide
        soledad Nicolas Malin added a comment - - edited

        I agree it"s technical information not really interesting for end/(middle ) user.
        I commit the patch at revision on trunk at 1718970

        We can spread on 14.12 if no opposition about this

        Thanks Pierre for this patch

        Show
        soledad Nicolas Malin added a comment - - edited I agree it"s technical information not really interesting for end/(middle ) user. I commit the patch at revision on trunk at 1718970 We can spread on 14.12 if no opposition about this Thanks Pierre for this patch
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Nicolas, why should we backport? I don't see the necessity.

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Nicolas, why should we backport? I don't see the necessity.
        Hide
        soledad Nicolas Malin added a comment -

        Why ?

        Why not ! Because YES we can ^^ .
        Your response to my ask, so I close only.

        Show
        soledad Nicolas Malin added a comment - Why ? Why not ! Because YES we can ^^ . Your response to my ask, so I close only.
        Hide
        pfm.smits Pierre Smits added a comment -

        Waiting to incorporate this in the next release (branch) and not in 14.12 means that this won't be available to adopters within 2 years. That is a long time. As we are still not having a release out regarding the 14.12 branch, I would say: help our adopters to avoid addressing this themselves. The risk is low.

        Show
        pfm.smits Pierre Smits added a comment - Waiting to incorporate this in the next release (branch) and not in 14.12 means that this won't be available to adopters within 2 years. That is a long time. As we are still not having a release out regarding the 14.12 branch, I would say: help our adopters to avoid addressing this themselves. The risk is low.
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        The risk is low, but the advantage is also low. Don't break the rule when it's not really needed I'd say, you know the story of the wolf?

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited The risk is low, but the advantage is also low. Don't break the rule when it's not really needed I'd say, you know the story of the wolf?

          People

          • Assignee:
            soledad Nicolas Malin
            Reporter:
            pfm.smits Pierre Smits
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development