Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6691

Remove tooltip="${uiLabelMap.CommonRequired}" from fields

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Pending Closed
    • Trunk
    • 16.11.01
    • ALL APPLICATIONS

    Description

      The aspect 'required-field="true"' should deliver this. Therefor, this is unnecessary.

      Attachments

        Issue Links

          Activity

            We maybe not want to systematically have the tooltip?

            jleroux Jacques Le Roux added a comment - We maybe not want to systematically have the tooltip?
            pierresmits Pierre Smits added a comment - - edited

            So you want to have specific tooltip for required fields adding hard coded redundancy on top of the 'required-field="true" attribute, while (at the same time) the rendering function in htmlFormMacroLibrary.ftl can deliver the same dynamically?

            pierresmits Pierre Smits added a comment - - edited So you want to have specific tooltip for required fields adding hard coded redundancy on top of the 'required-field="true" attribute, while (at the same time) the rendering function in htmlFormMacroLibrary.ftl can deliver the same dynamically?

            Nope, simply not make the tooltip necessary

            jleroux Jacques Le Roux added a comment - Nope, simply not make the tooltip necessary
            jleroux Jacques Le Roux added a comment - - edited

            I agree about simply removing all

            <<tooltip="${uiLabelMap.CommonRequired}">> 
            

            entries. I see some useless redundancy with that aspect. But I don't agree about systematically

            'required-field="true"' should deliver this.

            See my point?

            jleroux Jacques Le Roux added a comment - - edited I agree about simply removing all <<tooltip= "${uiLabelMap.CommonRequired}" >> entries. I see some useless redundancy with that aspect. But I don't agree about systematically 'required-field="true"' should deliver this. See my point?
            pierresmits Pierre Smits added a comment -

            Read my previous posting again: it said that the rendering furnction can deliver this.

            Whether third parties want to have it as such they can take care of it themselves. And if there is consensus regarding the 'should' or must aspect leading to changing the renderer then we have a point validating the requirement and we can plan accordingly.

            pierresmits Pierre Smits added a comment - Read my previous posting again: it said that the rendering furnction can deliver this. Whether third parties want to have it as such they can take care of it themselves. And if there is consensus regarding the 'should' or must aspect leading to changing the renderer then we have a point validating the requirement and we can plan accordingly.

            OK I'm not used to discuss about what 3rd parties does or not. For me it's just about what the issue title says not the description, doing so.

            jleroux Jacques Le Roux added a comment - OK I'm not used to discuss about what 3rd parties does or not. For me it's just about what the issue title says not the description, doing so.

            OK, this must be done after OFBIZ-6690

            jleroux Jacques Le Roux added a comment - OK, this must be done after OFBIZ-6690

            Instead of a quiet S/R action, this was an unexpected pain in the ass. A considerable number of forms:
            EmployeeForms.xml
            EmploymentForms.xml
            EmplPositionForms.xml
            GlobalHRSettingForms.xml
            RecruitmentForms.xml
            QuoteForms.xml
            PartyForms.xml
            StoreForms.xml
            ContactForms.xml
            FixedAssetForms.xml
            TaskForms.xml
            scrumForms.xml
            TaskForms.xml
            contained a large number of fields with

            tooltip="${uiLabelMap.CommonRequired}"
            

            but no

            required-field="true"
            

            Of course display and display-entity should not be concerned, I spotted a number of them in the lot.

            I also removed a bunch of harcoded * at end of labels (those followed by required-field="true") and spotted a number of others }*" who still need to be carefully reviewed to see if required=true is not missing there :/

            jleroux Jacques Le Roux added a comment - Instead of a quiet S/R action, this was an unexpected pain in the ass. A considerable number of forms: EmployeeForms.xml EmploymentForms.xml EmplPositionForms.xml GlobalHRSettingForms.xml RecruitmentForms.xml QuoteForms.xml PartyForms.xml StoreForms.xml ContactForms.xml FixedAssetForms.xml TaskForms.xml scrumForms.xml TaskForms.xml contained a large number of fields with tooltip= "${uiLabelMap.CommonRequired}" but no required-field= " true " Of course display and display-entity should not be concerned, I spotted a number of them in the lot. I also removed a bunch of harcoded * at end of labels (those followed by required-field="true" ) and spotted a number of others }*" who still need to be carefully reviewed to see if required=true is not missing there :/

            Commited at revision: 1709882

            I don't close because this needs more work as explained above

            jleroux Jacques Le Roux added a comment - Commited at revision: 1709882 I don't close because this needs more work as explained above
            nmalin Nicolas Malin added a comment -

            It's good way to clean all different case to define a require field.
            I asked myself the question on the asterisk macro utility. I think is linked to the theme and how is define, so maybe why don't need it

            nmalin Nicolas Malin added a comment - It's good way to clean all different case to define a require field. I asked myself the question on the asterisk macro utility. I think is linked to the theme and how is define, so maybe why don't need it
            adrianc@hlmksw.com Adrian Crum added a comment -

            Originally, OFBiz marked required fields with an asterisk - but it didn't include an explanation of what the asterisk meant. So, the 'required' CSS class and text was added to make it clearer that a field is required. The conversion was incomplete, so there are still asterisks in the project.

            adrianc@hlmksw.com Adrian Crum added a comment - Originally, OFBiz marked required fields with an asterisk - but it didn't include an explanation of what the asterisk meant. So, the 'required' CSS class and text was added to make it clearer that a field is required. The conversion was incomplete, so there are still asterisks in the project.
            nmalin Nicolas Malin added a comment -

            Thks for the history reminding

            Adrian you confirm that the asterisk haven't an utility now ? My translation is ambiguous

            nmalin Nicolas Malin added a comment - Thks for the history reminding Adrian you confirm that the asterisk haven't an utility now ? My translation is ambiguous

            We could remove the asterisk, but why not keep it? It's like a Stop signal on roads. Your brain identifies it w/o reading, faster than reading a word, but you will not notice...

            Anyway the most important part is that if a form contains a required fields the jQuery Validation plugin will be called on this form.
            This is what we should verify about the remaining fields with }*", do they need required-field="true" or not (I guess they need).
            We should also remove the required-field="true" used in display and display-entity fields

            jleroux Jacques Le Roux added a comment - We could remove the asterisk, but why not keep it? It's like a Stop signal on roads. Your brain identifies it w/o reading, faster than reading a word, but you will not notice... Anyway the most important part is that if a form contains a required fields the jQuery Validation plugin will be called on this form. This is what we should verify about the remaining fields with }*", do they need required-field="true" or not (I guess they need). We should also remove the required-field="true" used in display and display-entity fields
            pierresmits Pierre Smits added a comment -

            You're referring to hard coded * in the widgets, and elsewhere?

            Removing required-field="true" makes sense in display(-entity) fields.

            So does removing tooltip="${uiLabelMap.CommonRequired} on the same, or tooltip="${uiLabelMap.CommonNotModifRecreat}"

            pierresmits Pierre Smits added a comment - You're referring to hard coded * in the widgets, and elsewhere? Removing required-field="true" makes sense in display(-entity) fields. So does removing tooltip="${uiLabelMap.CommonRequired} on the same, or tooltip="${uiLabelMap.CommonNotModifRecreat}"

            >You're referring to hard coded * in the widgets, and elsewhere?
            widget forms

            >CommonNotModifRecreat
            unrelated

            jleroux Jacques Le Roux added a comment - >You're referring to hard coded * in the widgets, and elsewhere? widget forms >CommonNotModifRecreat unrelated

            At r1710086, I have replaced all }*" by requiredField but for forms using auto-fields-entity or auto-fields-service for which I created the subtask "Enhance auto-fields-entity and auto-fields-service to generate required fields on PK ones" at OFBIZ-6695

            jleroux Jacques Le Roux added a comment - At r1710086, I have replaced all }*" by requiredField but for forms using auto-fields-entity or auto-fields-service for which I created the subtask "Enhance auto-fields-entity and auto-fields-service to generate required fields on PK ones" at OFBIZ-6695

            OFBIZ-6695 needs to be done before closing here

            jleroux Jacques Le Roux added a comment - OFBIZ-6695 needs to be done before closing here

            At r1710093 I removed nonsensical required-field="true" for <display* field types

            jleroux Jacques Le Roux added a comment - At r1710093 I removed nonsensical required-field="true" for <display* field types
            pierresmits Pierre Smits added a comment -

            Thanks Jacques.

            pierresmits Pierre Smits added a comment - Thanks Jacques.
            pierresmits Pierre Smits added a comment -

            Thanks for the assistance, jacques.le.roux

            pierresmits Pierre Smits added a comment - Thanks for the assistance, jacques.le.roux

            People

              pierresmits Pierre Smits
              pierresmits Pierre Smits
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: