Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: order
    • Labels:
    • Sprint:
      Bug Crush Event - 21/2/2015

      Activity

      Hide
      pfm.smits Pierre Smits added a comment -

      This patch addresses the issue.

      Show
      pfm.smits Pierre Smits added a comment - This patch addresses the issue.
      Hide
      jacques.le.roux Jacques Le Roux added a comment -

      Thanks Pierre,

      Your patch is in trunk at revision: 1708969 as an improvement

      Show
      jacques.le.roux Jacques Le Roux added a comment - Thanks Pierre, Your patch is in trunk at revision: 1708969 as an improvement
      Hide
      deepak.dixit Deepak Dixit added a comment -

      I think we need to add fromDate as part of primary key as well.

      Show
      deepak.dixit Deepak Dixit added a comment - I think we need to add fromDate as part of primary key as well.
      Hide
      jacques.le.roux Jacques Le Roux added a comment -

      That makes sense indeed Deepak

      Show
      jacques.le.roux Jacques Le Roux added a comment - That makes sense indeed Deepak
      Hide
      deepak.dixit Deepak Dixit added a comment -

      Thanks Jacques,

      So as we are going to update PK of QuoteRole entity so we have to make it Deprecated and need to add data migration service.
      https://cwiki.apache.org/confluence/display/OFBIZ/General+Entity+Overview#GeneralEntityOverview-DeprecatedEntities

      Show
      deepak.dixit Deepak Dixit added a comment - Thanks Jacques, So as we are going to update PK of QuoteRole entity so we have to make it Deprecated and need to add data migration service. https://cwiki.apache.org/confluence/display/OFBIZ/General+Entity+Overview#GeneralEntityOverview-DeprecatedEntities
      Hide
      pfm.smits Pierre Smits added a comment -

      In stead of reopening a closed issue, creating a new one would make sense too.

      Show
      pfm.smits Pierre Smits added a comment - In stead of reopening a closed issue, creating a new one would make sense too.
      Hide
      jacques.le.roux Jacques Le Roux added a comment -

      Hi Deepak, Pierre,

      I agree with both of you.

      Show
      jacques.le.roux Jacques Le Roux added a comment - Hi Deepak, Pierre, I agree with both of you.
      Hide
      pfm.smits Pierre Smits added a comment -

      Reopening due to incorrect setting of the resolution.

      Show
      pfm.smits Pierre Smits added a comment - Reopening due to incorrect setting of the resolution.
      Hide
      pfm.smits Pierre Smits added a comment -

      Closing with correct setting given the type of the issue.

      Show
      pfm.smits Pierre Smits added a comment - Closing with correct setting given the type of the issue.

        People

        • Assignee:
          pfm.smits Pierre Smits
          Reporter:
          pfm.smits Pierre Smits
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development

              Agile