Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6692 Improve xsd definitions
  3. OFBIZ-6667

Remove limitation regarding menu-name in ofbiz-component.xsd

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: framework
    • Labels:

      Description

      Currently the following is in the ofbiz-component.xsd:

              <xs:attribute name="menu-name" default="main">
                  <xs:simpleType>
                      <xs:restriction base="xs:token">
                          <xs:enumeration value="main"/>
                          <xs:enumeration value="secondary"/>
                      </xs:restriction>
                  </xs:simpleType>
              </xs:attribute>
      

      However, this is limiting the options that can be applied generates unnecessary errors when developers opt for another methodology.

      1. OFBIZ-6667.patch
        2 kB
        Jacques Le Roux
      2. OFBIZ-6667-ofbiz-component.xsd.patch
        2 kB
        Pierre Smits

        Activity

        Hide
        pfm.smits Pierre Smits added a comment -

        This patch addresses the issue.

        Show
        pfm.smits Pierre Smits added a comment - This patch addresses the issue.
        Hide
        anilpatel Anil K Patel added a comment -

        Pierre,
        The proposed enhancement look good to me. Lets see what others have to say on it.
        Anil

        Show
        anilpatel Anil K Patel added a comment - Pierre, The proposed enhancement look good to me. Lets see what others have to say on it. Anil
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Don't we lose some information about main and secondary here? I also understand that those values are OOTB (and not even in all themes) so maybe just a sentence about it in the documentation attribute would be cool?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Don't we lose some information about main and secondary here? I also understand that those values are OOTB (and not even in all themes) so maybe just a sentence about it in the documentation attribute would be cool?
        Hide
        pfm.smits Pierre Smits added a comment -

        How would we lose that? Main is by default the designated menu when nothing has been set in ofbiz-component, and the others need to be explicitly set. Any other menu name must be dealt with in each theme.

        Show
        pfm.smits Pierre Smits added a comment - How would we lose that? Main is by default the designated menu when nothing has been set in ofbiz-component, and the others need to be explicitly set. Any other menu name must be dealt with in each theme.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I was just thinking at some more documentation, here is an updated patch

        Show
        jacques.le.roux Jacques Le Roux added a comment - I was just thinking at some more documentation, here is an updated patch
        Hide
        pfm.smits Pierre Smits added a comment -

        Documentation is always beneficial to both adopters and contributors. Keep it up!

        Show
        pfm.smits Pierre Smits added a comment - Documentation is always beneficial to both adopters and contributors. Keep it up!
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Pierre,

        Your extended patch is in trunk at revision: 1739968

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Pierre, Your extended patch is in trunk at revision: 1739968

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            pfm.smits Pierre Smits
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development