Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6654

Display of a recurrent workeffort in workeffort calendar do not respect estimatedStart/CompletionDate

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Release Branch 12.04, Release Branch 13.07, Release Branch 14.12, Trunk
    • Fix Version/s: 14.12.01, 12.04.06, 13.07.03, 16.11.01
    • Component/s: workeffort
    • Labels:
      None

      Description

      I created DAILY_GRIND recurrent workeffort with estimated start date to 2015-09-02 and estimated completion date to 2015-09-22. The task is displayed every day in the month.

      1. OFBIZ-6654.patch
        2 kB
        Gil Portenseigne
      2. screenshot-1.png
        75 kB
        Gil Portenseigne
      3. screenshot-2.png
        80 kB
        Gil Portenseigne

        Activity

        Hide
        adrianc@hlmksw.com Adrian Crum added a comment -

        The good news is the expression recognized September 7 as a federal holiday.

        Show
        adrianc@hlmksw.com Adrian Crum added a comment - The good news is the expression recognized September 7 as a federal holiday.
        Hide
        gil portenseigne Gil Portenseigne added a comment -

        I think that getWorkEffortEventsByPeriod service need the fix, got one but i'd like some feedback about using recurrencies and workeffort.

        Indeed I wonder if it's not absurd to use actualXXXXDate for recurrent workeffort (I tested it and calendar display something not regular). Studying getWorkEffortEventsByPeriod service make me wondering about actualXXXDate recurrent workeffort...

        i'll attach my first patch to exclude occurence out of the limits of workeffort start and completion dates. Opinions are welcome !

        Show
        gil portenseigne Gil Portenseigne added a comment - I think that getWorkEffortEventsByPeriod service need the fix, got one but i'd like some feedback about using recurrencies and workeffort. Indeed I wonder if it's not absurd to use actualXXXXDate for recurrent workeffort (I tested it and calendar display something not regular). Studying getWorkEffortEventsByPeriod service make me wondering about actualXXXDate recurrent workeffort... i'll attach my first patch to exclude occurence out of the limits of workeffort start and completion dates. Opinions are welcome !
        Hide
        gil portenseigne Gil Portenseigne added a comment -

        I might be missing something in the second loop of the service, but this patch will make the display of a estimatedXXX recurrent workeffort good

        Show
        gil portenseigne Gil Portenseigne added a comment - I might be missing something in the second loop of the service, but this patch will make the display of a estimatedXXX recurrent workeffort good
        Hide
        gil portenseigne Gil Portenseigne added a comment -

        Yeah, Temporal Expression are fine in my tests

        Show
        gil portenseigne Gil Portenseigne added a comment - Yeah, Temporal Expression are fine in my tests
        Hide
        adrianc@hlmksw.com Adrian Crum added a comment -

        Using the actual date-time fields does not make sense. The temporal expression is used to indicate something that happens repeatedly, like a scheduled event. Using the DAILY_GRIND expression as an example, the expression tells you when your work day is supposed to start, but you might show up late. Your actual arrival time is stored in the actual date-time fields.

        Show
        adrianc@hlmksw.com Adrian Crum added a comment - Using the actual date-time fields does not make sense. The temporal expression is used to indicate something that happens repeatedly, like a scheduled event. Using the DAILY_GRIND expression as an example, the expression tells you when your work day is supposed to start, but you might show up late. Your actual arrival time is stored in the actual date-time fields.
        Hide
        gil portenseigne Gil Portenseigne added a comment -

        Many thanks for the feedback, it's what i imagined, and I guess actual date-time will be stored on a new workeffort for each day.

        Show
        gil portenseigne Gil Portenseigne added a comment - Many thanks for the feedback, it's what i imagined, and I guess actual date-time will be stored on a new workeffort for each day.
        Hide
        gil portenseigne Gil Portenseigne added a comment -

        Better fix, ignoring temporal expression for actual dated workeffort

        Show
        gil portenseigne Gil Portenseigne added a comment - Better fix, ignoring temporal expression for actual dated workeffort
        Hide
        gil portenseigne Gil Portenseigne added a comment -

        Commited in
        trunk r1707791
        R14.12 r1707792
        R13.07 r1707793
        R12.04 r1707794

        Show
        gil portenseigne Gil Portenseigne added a comment - Commited in trunk r1707791 R14.12 r1707792 R13.07 r1707793 R12.04 r1707794
        Hide
        mbrohl Michael Brohl added a comment -

        Hi Gil,

        you should also close this ticket

        Happy coding,

        Michael

        Show
        mbrohl Michael Brohl added a comment - Hi Gil, you should also close this ticket Happy coding, Michael
        Hide
        gil portenseigne Gil Portenseigne added a comment -

        oops Thanks for the reminder

        Show
        gil portenseigne Gil Portenseigne added a comment - oops Thanks for the reminder

          People

          • Assignee:
            gil portenseigne Gil Portenseigne
            Reporter:
            gil portenseigne Gil Portenseigne
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development