Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9440 Refactor the Lucene and Solr Components
  3. OFBIZ-6595

Have the ability to test solr queries through widgets (screens & forms)

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Incomplete
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: solr
    • Labels:
      None

      Description

      Adding widgest (screens, forms, etc) so that an end-user can execute a search against the data indexed would enhance the applicability of the application.

        Issue Links

          Activity

          Hide
          pfm.smits Pierre Smits added a comment -

          This patch is the first increment to address the issue. Please feel free to test drive and provide feedback

          Currently it includes the following aspects:

          • SolrMenus.xml - providing the application menu, items:
            • main - opening the start screen of the app
            • admin - opening the Solr admin page in a new target
            • newquery - opening the query screen
          • SolrScreens.xml - defining Solr specific screen widgets
          • CommonScreens.xml - defining the common screens for Solr specific screen widgets
          • SolrUiLabels.xml - defining Solr app specific labels
          • SolrForms.xml - defining Solr specific form widgets
          • controller.xml - (re)defining request-map and view-map re widgets

          This file also includes a modification to web.xml of the Solr component, changing the mainDecoratorLocation

          Show
          pfm.smits Pierre Smits added a comment - This patch is the first increment to address the issue. Please feel free to test drive and provide feedback Currently it includes the following aspects: SolrMenus.xml - providing the application menu, items: main - opening the start screen of the app admin - opening the Solr admin page in a new target newquery - opening the query screen SolrScreens.xml - defining Solr specific screen widgets CommonScreens.xml - defining the common screens for Solr specific screen widgets SolrUiLabels.xml - defining Solr app specific labels SolrForms.xml - defining Solr specific form widgets controller.xml - (re)defining request-map and view-map re widgets This file also includes a modification to web.xml of the Solr component, changing the mainDecoratorLocation
          Hide
          pfm.smits Pierre Smits added a comment -

          This patch currently doesn't include functionality to execute a query through widgets and show the result.

          Show
          pfm.smits Pierre Smits added a comment - This patch currently doesn't include functionality to execute a query through widgets and show the result.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks Pierre

          Your 1st patch is commited in trunk at revision: 1736878

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks Pierre Your 1st patch is commited in trunk at revision: 1736878
          Hide
          amardeepsj Amardeep Singh Jhajj added a comment -

          Hi Pierre,

          I have some questions in my mind about this issue-

          1. How we are going to help end users here to execute query on Solr index to enhance applicability of application?
          2. And how it will be different and better than Solr admin query tool (https://localhost:8443/solr/#/solrdefault/query)?. If its the same then why do we need it in the first place?
          3. Are you planning to have query browser like we have in JIRA search navigator using jql? Example: https://issues.apache.org/jira/issues/?jql=project%20%3D%20OFBIZ
          4. What is the status of this issue now? currently I can see functionality is incomplete (rather we would say functionality is broken).

          Please let us know your thoughts and let me know if I can assist you in moving forward. Thanks

          Show
          amardeepsj Amardeep Singh Jhajj added a comment - Hi Pierre, I have some questions in my mind about this issue- 1. How we are going to help end users here to execute query on Solr index to enhance applicability of application? 2. And how it will be different and better than Solr admin query tool ( https://localhost:8443/solr/#/solrdefault/query)? . If its the same then why do we need it in the first place? 3. Are you planning to have query browser like we have in JIRA search navigator using jql? Example: https://issues.apache.org/jira/issues/?jql=project%20%3D%20OFBIZ 4. What is the status of this issue now? currently I can see functionality is incomplete (rather we would say functionality is broken). Please let us know your thoughts and let me know if I can assist you in moving forward. Thanks
          Hide
          mbrohl Michael Brohl added a comment -

          I just stumbled upon this during my work on OFBIZ-9440.

          As Amardeep said, the functionality is incomplete. For the average user, the query widget pretends to provide a search functionality but there is nothing more than this widget (like Pierre rightly mentioned providing the patch).
          I see no reason why this work was committed in this state because it only causes confusion. We should definitely be more cautious when adding new functionality to the codebase.

          In a case like this, we should have waited until the work provides a minimum of functionality and ist tested accordingly.

          I will add this as a subtask to the refactoring issue and work out a minimal functional solution in the course of this work.

          Show
          mbrohl Michael Brohl added a comment - I just stumbled upon this during my work on OFBIZ-9440 . As Amardeep said, the functionality is incomplete. For the average user, the query widget pretends to provide a search functionality but there is nothing more than this widget (like Pierre rightly mentioned providing the patch). I see no reason why this work was committed in this state because it only causes confusion. We should definitely be more cautious when adding new functionality to the codebase. In a case like this, we should have waited until the work provides a minimum of functionality and ist tested accordingly. I will add this as a subtask to the refactoring issue and work out a minimal functional solution in the course of this work.
          Hide
          mbrohl Michael Brohl added a comment -

          Jacques Le Roux, do you mind if I assign this issue to myself?

          Show
          mbrohl Michael Brohl added a comment - Jacques Le Roux , do you mind if I assign this issue to myself?
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Not at all, please do Michael

          Show
          jacques.le.roux Jacques Le Roux added a comment - Not at all, please do Michael
          Hide
          mbrohl Michael Brohl added a comment -

          Pierre Smits,

          can you please give us some answers to the questions of Amardeep Singh Jhajj?

          If the query functionality does not differ from the Solr Admin and we are not going to make it functional, I propose to remove it from the codebase and put a link to the Solr Admin instead.

          Thank you.

          Show
          mbrohl Michael Brohl added a comment - Pierre Smits , can you please give us some answers to the questions of Amardeep Singh Jhajj ? If the query functionality does not differ from the Solr Admin and we are not going to make it functional, I propose to remove it from the codebase and put a link to the Solr Admin instead. Thank you.
          Hide
          mbrohl Michael Brohl added a comment - - edited

          Hi Pierre Smits,

          without further reaction to the discussion, I will take action to close this ticket as "Incomplete" and remove the unfinished functionality from the codebase in 7 days.
          This should not go into a release in this state.

          Thanks,
          Michael

          Show
          mbrohl Michael Brohl added a comment - - edited Hi Pierre Smits , without further reaction to the discussion, I will take action to close this ticket as "Incomplete" and remove the unfinished functionality from the codebase in 7 days. This should not go into a release in this state. Thanks, Michael
          Hide
          mbrohl Michael Brohl added a comment -

          I've removed unfinished Solr query functionality from the
          codebase which was introduced with r1736878.

          There is no need for a self-implemented solr query form, this is
          already provided by the Solr admin page which is accessible
          through the menu.

          Done in r1812583.

          Show
          mbrohl Michael Brohl added a comment - I've removed unfinished Solr query functionality from the codebase which was introduced with r1736878. There is no need for a self-implemented solr query form, this is already provided by the Solr admin page which is accessible through the menu. Done in r1812583.

            People

            • Assignee:
              mbrohl Michael Brohl
              Reporter:
              pfm.smits Pierre Smits
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development