Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6594

Wrong Documentation for Temporal Expressions

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Release Branch 12.04, Release Branch 13.07, Release Branch 14.12, 16.11.01
    • Fix Version/s: 14.12.01, 12.04.06, 13.07.03
    • Component/s: None
    • Labels:
      None
    • Sprint:
      Community Day 3 - 2015

      Description

      If the temporal expression is referring to com.ibm.icu.util.Calendar,
      the HOUR is ment to be a 10 instead of an 11.
      The mechanism works fine, just the documentation is wrong.

      1. ServiceDemoData.xml.patch
        0.7 kB
        Mirko Vogelsmeier

        Activity

        Hide
        pfm.smits Pierre Smits added a comment -

        I shouldn't regard issues regarding documentation as 'trivial'. Good documentation helps all. It ensures that we avoid having issues registered due to misunderstanding.

        Show
        pfm.smits Pierre Smits added a comment - I shouldn't regard issues regarding documentation as 'trivial'. Good documentation helps all. It ensures that we avoid having issues registered due to misunderstanding.
        Hide
        pfm.smits Pierre Smits added a comment -

        Shouldn't we consider replacing the calendar library?

        Currently we are using 'import com.ibm.icu.util.Calendar' at various places. But we're also using 'java.util.Calendar' at other places.
        Better is it to make a choice for consistency.

        Show
        pfm.smits Pierre Smits added a comment - Shouldn't we consider replacing the calendar library? Currently we are using 'import com.ibm.icu.util.Calendar' at various places. But we're also using 'java.util.Calendar' at other places. Better is it to make a choice for consistency.
        Hide
        mbrohl Michael Brohl added a comment -

        I had the same thought as I saw the reference to com.ibm.icu.util.Calendar.
        But this has to be another issue.

        Show
        mbrohl Michael Brohl added a comment - I had the same thought as I saw the reference to com.ibm.icu.util.Calendar. But this has to be another issue.
        Hide
        pfm.smits Pierre Smits added a comment -

        +1

        Show
        pfm.smits Pierre Smits added a comment - +1
        Hide
        mbrohl Michael Brohl added a comment -

        The fix is in
        trunk r1703965
        release-branch 12.04 r1703968
        release-branch 13.07 r1703967
        release-branch 14.12 r1703965

        Thanks Mirco!

        Show
        mbrohl Michael Brohl added a comment - The fix is in trunk r1703965 release-branch 12.04 r1703968 release-branch 13.07 r1703967 release-branch 14.12 r1703965 Thanks Mirco!
        Hide
        mbrohl Michael Brohl added a comment -

        You are right, Pierre. Changed it back to minor.

        Show
        mbrohl Michael Brohl added a comment - You are right, Pierre. Changed it back to minor.

          People

          • Assignee:
            mbrohl Michael Brohl
            Reporter:
            vogelsme Mirko Vogelsmeier
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile