Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6566

SecurityGroup doesn't get removed from a Party

    Details

      Description

      When trying to remove a security group from a party (e.g. DemoCustomer, see http://demo-trunk-ofbiz.apache.org/partymgr/control/ProfileEditUserLoginSecurityGroups?partyId=DemoCustomer&userLoginId=DemoCustomer), the security group doesn't get removed.

      request-map ProfileRemoveUserLoginFromSecurityGroup

      1. OFBIZ-6566.patch
        2 kB
        Neeraj Kumawat
      2. RemoveSecurityGroup.patch
        3 kB
        Neeraj Kumawat
      3. RemoveSecurityGroup.patch1
        2 kB
        Neeraj Kumawat

        Activity

        Hide
        neeraj.kumawat Neeraj Kumawat added a comment -

        Hi Pierre Smits,
        I have took checkout from ofbiz trunk, and checked this issue. i have fixed this issue.
        But How can i contribute my changes regarding this fix to ofbiz.
        Can you please help me regarding that.

        Show
        neeraj.kumawat Neeraj Kumawat added a comment - Hi Pierre Smits, I have took checkout from ofbiz trunk, and checked this issue. i have fixed this issue. But How can i contribute my changes regarding this fix to ofbiz. Can you please help me regarding that.
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Hi Neeraj,

        You can create patch and upload here.
        You can refer http://svnbook.red-bean.com/en/1.7/svn.ref.svn.c.diff.html to create patch.

        Show
        deepak.dixit Deepak Dixit added a comment - Hi Neeraj, You can create patch and upload here. You can refer http://svnbook.red-bean.com/en/1.7/svn.ref.svn.c.diff.html to create patch.
        Hide
        neeraj.kumawat Neeraj Kumawat added a comment -

        Thanks Deepak for helping me.
        I have attached the patch for this issue.

        Show
        neeraj.kumawat Neeraj Kumawat added a comment - Thanks Deepak for helping me. I have attached the patch for this issue.
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Thanks Neeraj for uploading the patch, svn format patch is preferable.

        If you are using git then you can create patch using git diff --no-prefix

        Show
        deepak.dixit Deepak Dixit added a comment - Thanks Neeraj for uploading the patch, svn format patch is preferable. If you are using git then you can create patch using git diff --no-prefix
        Hide
        neeraj.kumawat Neeraj Kumawat added a comment -

        Thanks Deepak.
        I have created patch with git diff --no-prefix and uploaded the same.
        Can you please check that this patch set format is correct or not?

        Show
        neeraj.kumawat Neeraj Kumawat added a comment - Thanks Deepak. I have created patch with git diff --no-prefix and uploaded the same. Can you please check that this patch set format is correct or not?
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Neeraj, I think again you created patch in wrong way....
        Please try once again, and one more thing you can upload patch with same name, and we generally follow the TASK-ID.patch pattern.

        Show
        deepak.dixit Deepak Dixit added a comment - Neeraj, I think again you created patch in wrong way.... Please try once again, and one more thing you can upload patch with same name, and we generally follow the TASK-ID.patch pattern.
        Hide
        neeraj.kumawat Neeraj Kumawat added a comment -

        Hi Deepak,
        I have uploaded new patch. Can you please check this format and name once again.

        Show
        neeraj.kumawat Neeraj Kumawat added a comment - Hi Deepak, I have uploaded new patch. Can you please check this format and name once again.
        Hide
        deepak.dixit Deepak Dixit added a comment - - edited

        IMO its not a bug, so changed the issue type from Bug to improvement.
        Thanks Pierre Smits and Neeraj Kumawat. Your patch is in trunk at r#1696234

        Show
        deepak.dixit Deepak Dixit added a comment - - edited IMO its not a bug, so changed the issue type from Bug to improvement. Thanks Pierre Smits and Neeraj Kumawat. Your patch is in trunk at r#1696234
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        Thought it could be considered an improvement (moot point) I backported to
        R14.12 r1696570
        R13.07 r1696571
        R12.04 r1696572
        because it was simple and safe

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited Thought it could be considered an improvement (moot point) I backported to R14.12 r1696570 R13.07 r1696571 R12.04 r1696572 because it was simple and safe

          People

          • Assignee:
            deepak.dixit Deepak Dixit
            Reporter:
            pfm.smits Pierre Smits
          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development