Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6528

Add a mean to untie geo associations

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: framework
    • Labels:

      Description

      In the Webtools we can asociate Geos but we have yet no means to untie them

      1. OFBIZ-6528.patch
        8 kB
        Gil Portenseigne
      2. OFBIZ-6528.patch
        7 kB
        Gil Portenseigne

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks for report, just done

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks for report, just done
        Hide
        gil portenseigne Gil Portenseigne added a comment - - edited

        Thank you ! I like simplicity

        Reading the commit mail, could you just rename the

        +        <description>Delete a Geo</description>

        to

        +        <description>Delete a GeoAssoc</description>

        Sorry for this detail

        Show
        gil portenseigne Gil Portenseigne added a comment - - edited Thank you ! I like simplicity Reading the commit mail, could you just rename the + <description>Delete a Geo</description> to + <description>Delete a GeoAssoc</description> Sorry for this detail
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        Thanks guys,

        Gil your patch is commited at revision: 1687259, well thought!

        I also particularly like <<engine="entity-auto" invoke="delete">>

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited Thanks guys, Gil your patch is commited at revision: 1687259, well thought! I also particularly like <<engine="entity-auto" invoke="delete">>
        Hide
        gil portenseigne Gil Portenseigne added a comment -

        Double wire crossed, here is the updated patch.

        Show
        gil portenseigne Gil Portenseigne added a comment - Double wire crossed, here is the updated patch.
        Hide
        gil portenseigne Gil Portenseigne added a comment -

        Feel free, i can give another patch after your commit

        Show
        gil portenseigne Gil Portenseigne added a comment - Feel free, i can give another patch after your commit
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        OK cool, Gil, we crossed on wire, I will wait for your improvement

        Show
        jacques.le.roux Jacques Le Roux added a comment - OK cool, Gil, we crossed on wire, I will wait for your improvement
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Pierre, I was ready to commit, but I think I will before improve it as suggested, if nobody beats me on it

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Pierre, I was ready to commit, but I think I will before improve it as suggested, if nobody beats me on it
        Hide
        gil portenseigne Gil Portenseigne added a comment -

        Indeed it's quite simple to do, i'll update my patch soon.

        Show
        gil portenseigne Gil Portenseigne added a comment - Indeed it's quite simple to do, i'll update my patch soon.
        Hide
        pfm.smits Pierre Smits added a comment - - edited

        I have tested the patch. It works.

        However, the grid showing the geos associated doesn't provide a clickable to open the associated geo. That could be another improvement.

        Another plus would be to show the geoTypeId of the associated geo.

        Show
        pfm.smits Pierre Smits added a comment - - edited I have tested the patch. It works. However, the grid showing the geos associated doesn't provide a clickable to open the associated geo. That could be another improvement. Another plus would be to show the geoTypeId of the associated geo.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Gil, I will take care of that

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Gil, I will take care of that
        Hide
        gil portenseigne Gil Portenseigne added a comment -

        This patch add a new grid in EditGeoScreen to see/delete GeoAssoc.
        I had CommonEntityLabels default-resource-name on GeoAssocType for translation purpose.

        Show
        gil portenseigne Gil Portenseigne added a comment - This patch add a new grid in EditGeoScreen to see/delete GeoAssoc. I had CommonEntityLabels default-resource-name on GeoAssocType for translation purpose.

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            jacques.le.roux Jacques Le Roux
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development