Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6524

Cleaning forms code after setting default-value in list-options and entity-options

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: None
    • Labels:
      None
    • Sprint:
      Community Day 2 - 2015

      Description

      Cleaning forms code is needed after setting default-value in list-options and entity-options from OFBIZ-6490 and OFBIZ-6489.

      i.e. removing lots of

      description=${description}
      1. OFBIZ-6524.patch
        667 kB
        Gil Portenseigne

        Activity

        Hide
        soledad Nicolas Malin added a comment -

        Thanks Gil, c'est dans la boite !
        It's in trunk at revision 1686674

        Show
        soledad Nicolas Malin added a comment - Thanks Gil, c'est dans la boite ! It's in trunk at revision 1686674
        Hide
        gil portenseigne Gil Portenseigne added a comment -

        It's a big patch 10k+ lines.

        I use big replacements, and ckeck it afterward, first checking parts of the patch file, then with bash :

        grep "^-" OFBIZ-6524.patch | grep -v entity-option | grep -v list-option | grep -v display-entity | grep -v révision
        //this select replaced lines, then remove wanted corrections and revision lines

        I found some unwanting changes that i removed from the patch.

        Seems safe to apply

        Show
        gil portenseigne Gil Portenseigne added a comment - It's a big patch 10k+ lines. I use big replacements, and ckeck it afterward, first checking parts of the patch file, then with bash : grep "^-" OFBIZ-6524.patch | grep -v entity-option | grep -v list-option | grep -v display-entity | grep -v révision // this select replaced lines, then remove wanted corrections and revision lines I found some unwanting changes that i removed from the patch. Seems safe to apply

          People

          • Assignee:
            soledad Nicolas Malin
            Reporter:
            gil portenseigne Gil Portenseigne
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile