Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6513

countyGeoId and geoPointId fields are missing in PartyAndPostalAddress entity view

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: party
    • Labels:
      None

      Description

      Rather than adding both fields, I will rather add an allias-all. Then if ever we add new fields to PostalAddress they will not miss there.

      While at it I looked for such issues in other entity views based on PostalAddress. All but PartyExport (accounting) and ShipmentManifestView use an allias-all on PostalAddress.

      I think we should do the same for ShipmentManifestView but I'm not sure about PartyExport, though I don't see an issue there using an allias-all too.

      Opinions?

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I like more done instead of fixed here

        Show
        jacques.le.roux Jacques Le Roux added a comment - I like more done instead of fixed here
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        This is done and don't need backport

        Show
        jacques.le.roux Jacques Le Roux added a comment - This is done and don't need backport
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Another question is should we consider this a bug? I don't think so but it's a moot point, countyGeoId an GeoPointId are there for a long time already...

        Show
        jacques.le.roux Jacques Le Roux added a comment - Another question is should we consider this a bug? I don't think so but it's a moot point, countyGeoId an GeoPointId are there for a long time already...
        Hide
        pfm.smits Pierre Smits added a comment -

        It see no problems in this, nor for the other two referenced view-entites.

        Even adding a new address3 field should pose no problem.

        Show
        pfm.smits Pierre Smits added a comment - It see no problems in this, nor for the other two referenced view-entites. Even adding a new address3 field should pose no problem.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Done for PartyAndPostalAddress at revision 1686002.

        I will wait opinions before doing the same on the 2 other entity view.

        Show
        jacques.le.roux Jacques Le Roux added a comment - Done for PartyAndPostalAddress at revision 1686002. I will wait opinions before doing the same on the 2 other entity view.

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            jacques.le.roux Jacques Le Roux
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development