Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: ALL APPLICATIONS
    • Labels:
      None

      Description

        Issue Links

          Activity

          Hide
          pfm.smits Pierre Smits added a comment - - edited

          We can test for breaking code.

          Otherwise, we shouldn't make it to difficult for ourselves. Until a better proposition comes along, we can make due.

          Show
          pfm.smits Pierre Smits added a comment - - edited We can test for breaking code. Otherwise, we shouldn't make it to difficult for ourselves. Until a better proposition comes along, we can make due.
          Hide
          jacques.le.roux Jacques Le Roux added a comment - - edited

          BTW I can't get Markmail working today but here is the quetion I posted on the user ML then:

          All Devs,
          It went unnoticed (a bit by Adrian at https://issues.apache.org/jira/browse/OFBIZ-4270?focusedCommentId=13072722 )
          but I think Sascha went a bit too far by forcing CountryAddressFormat into GeoAssocAndGeoToWithState which is used into getAssociatedStateList() at
          http://svn.apache.org/viewvc?view=revision&revision=1153402

          2 solutions:

          • relax this constraint (will work in all cases)
          • provide new CountryAddressFormat for contries missing (when we will add a
            new country could "break" again)

          Opinions?

          It's finally here http://markmail.org/message/x7im7kyae3zztzup. I feel I should switch to Pony Mail for references, one day of the other commercial links Fail! Unfortunately I'm so used to MarkMail and it's so convenient and fast!

          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited BTW I can't get Markmail working today but here is the quetion I posted on the user ML then: All Devs, It went unnoticed (a bit by Adrian at https://issues.apache.org/jira/browse/OFBIZ-4270?focusedCommentId=13072722 ) but I think Sascha went a bit too far by forcing CountryAddressFormat into GeoAssocAndGeoToWithState which is used into getAssociatedStateList() at http://svn.apache.org/viewvc?view=revision&revision=1153402 2 solutions: relax this constraint (will work in all cases) provide new CountryAddressFormat for contries missing (when we will add a new country could "break" again) Opinions? It's finally here http://markmail.org/message/x7im7kyae3zztzup . I feel I should switch to Pony Mail for references, one day of the other commercial links Fail! Unfortunately I'm so used to MarkMail and it's so convenient and fast!
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Let me clarify, it's simple. I think you are right about CountryAddressFormat data which should not be in GeoData.xml but in specific GeoData_.xml country files as you did in your patch. Not only this one (Chile) but all. So I proposed you to create a Jira issue to state this and possibly attach a patch to move existing CountryAddressFormat data to specific GeoData_.xml country files. This also means to create a bunch of new specific GeoData_??.xml country files, we have only few currently and more (mostly empty so irrevelant) CountryAddressFormat data. Hope it's clearer

          Show
          jacques.le.roux Jacques Le Roux added a comment - Let me clarify, it's simple. I think you are right about CountryAddressFormat data which should not be in GeoData.xml but in specific GeoData_ .xml country files as you did in your patch. Not only this one (Chile) but all. So I proposed you to create a Jira issue to state this and possibly attach a patch to move existing CountryAddressFormat data to specific GeoData_ .xml country files. This also means to create a bunch of new specific GeoData_??.xml country files, we have only few currently and more (mostly empty so irrevelant) CountryAddressFormat data. Hope it's clearer
          Hide
          pfm.smits Pierre Smits added a comment - - edited

          Hmm. Are we to understand that you want me to propose a new approach regarding how we handle country specific data (disentanglement) in a set of separate JIRA improvement issues, but when patches get attached to those that you won't work together with the community to get those committed?

          I am confused by your earlier posting? Do you want the patch reattached to another issue?

          Show
          pfm.smits Pierre Smits added a comment - - edited Hmm. Are we to understand that you want me to propose a new approach regarding how we handle country specific data (disentanglement) in a set of separate JIRA improvement issues, but when patches get attached to those that you won't work together with the community to get those committed? I am confused by your earlier posting? Do you want the patch reattached to another issue?
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Sorry, I will not go this way.

          Show
          jacques.le.roux Jacques Le Roux added a comment - Sorry, I will not go this way.
          Hide
          pfm.smits Pierre Smits added a comment -

          Maybe you could start the approach off with reopening this issue and applying the attached patch as is? That would send a signal to the community too.

          Show
          pfm.smits Pierre Smits added a comment - Maybe you could start the approach off with reopening this issue and applying the attached patch as is? That would send a signal to the community too.
          Hide
          jacques.le.roux Jacques Le Roux added a comment - - edited

          That's a good point Pierre, it would also make it more prominent when people create new localised geo data by copying from one of the currents. That would answer a question I asked on the user ML but got no answers so far.

          Would you take care of that and propose a patch? Then in another Jira issue of course.

          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited That's a good point Pierre, it would also make it more prominent when people create new localised geo data by copying from one of the currents. That would answer a question I asked on the user ML but got no answers so far. Would you take care of that and propose a patch? Then in another Jira issue of course.
          Hide
          pfm.smits Pierre Smits added a comment -

          Shouldn't it be better to have that in a country specific GeoData xml file? That way people can opt to include or not...

          Show
          pfm.smits Pierre Smits added a comment - Shouldn't it be better to have that in a country specific GeoData xml file? That way people can opt to include or not...
          Hide
          jacques.le.roux Jacques Le Roux added a comment - - edited

          Thanks Pierre,

          At r1684105, I have not applied your patch as is because the CountryAddressFormat data are supposed to be in GeoData.xml

          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited Thanks Pierre, At r1684105, I have not applied your patch as is because the CountryAddressFormat data are supposed to be in GeoData.xml
          Hide
          pfm.smits Pierre Smits added a comment -

          This patch addresses the issue.

          Show
          pfm.smits Pierre Smits added a comment - This patch addresses the issue.

            People

            • Assignee:
              jacques.le.roux Jacques Le Roux
              Reporter:
              pfm.smits Pierre Smits
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development