Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-4183 Screen Link Ajax Windows
  3. OFBIZ-6359

Improves dialog boxes generated by layered-modal link parameter

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: framework
    • Labels:
      None
    • Sprint:
      Bug Crush Event - 21/2/2015, Community Day 1 - 2016

      Description

      There are few points I'd like to improve:

      • Add closeOnEscape (trivial)
      • Allow to pass parameters as hidden value
      • Consider also GET parameters put in the link target

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks!

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks!
        Hide
        soledad Nicolas Malin added a comment -

        I created an issue with it here OFBIZ-6804

        Show
        soledad Nicolas Malin added a comment - I created an issue with it here OFBIZ-6804
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        >What advantage compare to hidden parameters ?

        I don't clearly remember why I needed that. It was in a custom project which is now pending. Do we have an example where it's used OOTB?

        Show
        jacques.le.roux Jacques Le Roux added a comment - >What advantage compare to hidden parameters ? I don't clearly remember why I needed that. It was in a custom project which is now pending. Do we have an example where it's used OOTB?
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I did not test, just reviewed, that sounds good to me, thanks Nicolas!

        Show
        jacques.le.roux Jacques Le Roux added a comment - I did not test, just reviewed, that sounds good to me, thanks Nicolas!
        Hide
        soledad Nicolas Malin added a comment -

        Allow to pass parameters as hidden value

        done on trunk

        Consider also GET parameters put in the link target

        What advantage compare to hidden parameters ?
        Currently on the issue OFBIZ-6803 I passed all parameters come from context analyse on the data flow. If you pass a parameter directly on the url, it's works aslo.

        Show
        soledad Nicolas Malin added a comment - Allow to pass parameters as hidden value done on trunk Consider also GET parameters put in the link target What advantage compare to hidden parameters ? Currently on the issue OFBIZ-6803 I passed all parameters come from context analyse on the data flow. If you pass a parameter directly on the url, it's works aslo.
        Hide
        soledad Nicolas Malin added a comment - - edited

        Maybe you wish when the dialogbox would be close to refresh an area with quiet parameter ? like queryString on pagination list ?

        Show
        soledad Nicolas Malin added a comment - - edited Maybe you wish when the dialogbox would be close to refresh an area with quiet parameter ? like queryString on pagination list ?
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Might be helpful later https://api.jqueryui.com/dialog/

        Show
        jacques.le.roux Jacques Le Roux added a comment - Might be helpful later https://api.jqueryui.com/dialog/
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        closeOnEscape added at revision 1679172.

        Show
        jacques.le.roux Jacques Le Roux added a comment - closeOnEscape added at revision 1679172.

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            jacques.le.roux Jacques Le Roux
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile