Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6354

FOP rendered list form widgets do not work for fields with postition > 0

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: framework
    • Labels:
      None

      Description

      It doesn't work because of the way the renderFormatHeaderRowOpen is called causes the FOP renderer to create more than one <fo:table-header>.

      1. OFBIZ-6354_fop_text_xml.patch
        4 kB
        Christian Carlow
      2. OFBIZ-6354_htmlrender.patch
        1 kB
        Christian Carlow
      3. OFBIZ-6354.patch
        5 kB
        Christian Carlow

        Activity

        Hide
        ofbizzer Christian Carlow added a comment -

        This patch adds renderFormatHeaderOpen and renderFormatHeaderClose to separately generate <fo:table-header> for FOP and <thead> for html.

        Show
        ofbizzer Christian Carlow added a comment - This patch adds renderFormatHeaderOpen and renderFormatHeaderClose to separately generate <fo:table-header> for FOP and <thead> for html.
        Hide
        ofbizzer Christian Carlow added a comment -

        OFBIZ-6354_htmlrender.patch adds the new list form widget header methods to the deprecated HtmlFormRenderer needed by EmailServices.java to handle OFBIZ-6360 until replaced with MacroFormRender.

        Show
        ofbizzer Christian Carlow added a comment - OFBIZ-6354 _htmlrender.patch adds the new list form widget header methods to the deprecated HtmlFormRenderer needed by EmailServices.java to handle OFBIZ-6360 until replaced with MacroFormRender.
        Hide
        ofbizzer Christian Carlow added a comment -

        This additional patch handles the other FormRenderers FOP, Text, Xml. This issue is still a work in process.

        Show
        ofbizzer Christian Carlow added a comment - This additional patch handles the other FormRenderers FOP, Text, Xml. This issue is still a work in process.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I committed the 1st 2 patches but had to revert, more work to do here...

        FoFormRenderer is not abstract and does not override abstract method
        renderFormatHeaderClose(Appendable,Map<String,Object>,ModelForm) in
        FormStringRenderer
           [javac18] public class FoFormRenderer extends HtmlWidgetRenderer
        implements FormStringRenderer
        

        This was maybe working with Java 7?

        Show
        jacques.le.roux Jacques Le Roux added a comment - I committed the 1st 2 patches but had to revert, more work to do here... FoFormRenderer is not abstract and does not override abstract method renderFormatHeaderClose(Appendable,Map< String , Object >,ModelForm) in FormStringRenderer [javac18] public class FoFormRenderer extends HtmlWidgetRenderer implements FormStringRenderer This was maybe working with Java 7?
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Hi Jacques,

        Its not related to Java8, you need to override the renderFormatHeaderOpen and renderFormatHeaderClose method in following class as well:

        • FoFormRenderer.java
        • TextFormRenderer.java
        • XmlFormRenderer.java
        Show
        deepak.dixit Deepak Dixit added a comment - Hi Jacques, Its not related to Java8, you need to override the renderFormatHeaderOpen and renderFormatHeaderClose method in following class as well: FoFormRenderer.java TextFormRenderer.java XmlFormRenderer.java
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Deepak, actually I should have committed the 3rd patch but I got to quickly move then and forgot :/

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Deepak, actually I should have committed the 3rd patch but I got to quickly move then and forgot :/
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Christian,

        Your patches are in trunk at revision: 1710727

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Christian, Your patches are in trunk at revision: 1710727

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            ofbizzer Christian Carlow
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development