Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6332 Replacing bsh code with Groovy code
  3. OFBIZ-6333

Replacing bsh code with groovy Code in SCRUM screens, forms and menus

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: scrum
    • Labels:
      None

      Activity

      Hide
      pfm.smits Pierre Smits added a comment -

      This patch addresses the issue.

      Show
      pfm.smits Pierre Smits added a comment - This patch addresses the issue.
      Hide
      jacques.le.roux Jacques Le Roux added a comment -

      I see no patch

      Show
      jacques.le.roux Jacques Le Roux added a comment - I see no patch
      Hide
      pfm.smits Pierre Smits added a comment -

      That is correct. Current status is 'In progress'. I removed the patch as it was incomplete.

      Show
      pfm.smits Pierre Smits added a comment - That is correct. Current status is 'In progress'. I removed the patch as it was incomplete.
      Hide
      pfm.smits Pierre Smits added a comment -

      This patch addresses the issue.

      Show
      pfm.smits Pierre Smits added a comment - This patch addresses the issue.
      Hide
      jacques.le.roux Jacques Le Roux added a comment -

      Mmm, it's half baked, I wrote at

      Great, BTW when changing from BSH to groovy it would have been better to change from

      &

      (and such) to & (and such).
      But no worries that can be done automatically with a gloabl S/R in Eclipse after this umbrella has been closed (ie all sub-tasks done)

      but finally since there are cases where you need to be careful and cases with multi-lines changes I think it's better to do it "by hand" (ie local S/R)

      Show
      jacques.le.roux Jacques Le Roux added a comment - Mmm, it's half baked, I wrote at Great, BTW when changing from BSH to groovy it would have been better to change from & (and such) to & (and such). But no worries that can be done automatically with a gloabl S/R in Eclipse after this umbrella has been closed (ie all sub-tasks done) but finally since there are cases where you need to be careful and cases with multi-lines changes I think it's better to do it "by hand" (ie local S/R)
      Hide
      pfm.smits Pierre Smits added a comment -

      Hi Jacques,

      How do you mean 'half baked'?

      Show
      pfm.smits Pierre Smits added a comment - Hi Jacques, How do you mean 'half baked'?
      Hide
      jacques.le.roux Jacques Le Roux added a comment -

      I mean we should try to replace the &***; (HTML entity) by simple code when possible. That's the hardest part, a bsh/grrovy S/R can be done at any moment. Also no needs to have them separated we should do it in a sole patch, though this is a moot point (easier to apply, harder to review)

      Show
      jacques.le.roux Jacques Le Roux added a comment - I mean we should try to replace the &***; (HTML entity) by simple code when possible. That's the hardest part, a bsh/grrovy S/R can be done at any moment. Also no needs to have them separated we should do it in a sole patch, though this is a moot point (easier to apply, harder to review)
      Hide
      jacques.le.roux Jacques Le Roux added a comment -

      I'd do a "${bsh" -> "${groovy" in *.xml then S/R with some care on where to apply et voilà. I'd do that but I'd then prefer to also improve the code, else I don't see the point...

      Show
      jacques.le.roux Jacques Le Roux added a comment - I'd do a "${bsh" -> "${groovy" in *.xml then S/R with some care on where to apply et voilà. I'd do that but I'd then prefer to also improve the code, else I don't see the point...
      Hide
      jacques.le.roux Jacques Le Roux added a comment -

      Done at r1682118

      Show
      jacques.le.roux Jacques Le Roux added a comment - Done at r1682118

        People

        • Assignee:
          jacques.le.roux Jacques Le Roux
          Reporter:
          pfm.smits Pierre Smits
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development