Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6328

createProductionRunsForOrder service doesn't handle cancelled production runs

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: manufacturing
    • Labels:
      None

      Description

      createProductionRunsForOrder doesn't create production runs whenever a WorkOrderItemFulfillment record exists even if workEffort.currentStatusId == "PRUN_CANCELLED". The service should be enhanced to recognized canceled production runs and create replacements when no active ones are found.

      Extra logic may need to be added later to handle changing production run statuses from canceled back to an active state when another active production run took its place but as of right now such a status change is not possible.

      1. OFBIZ-6328.patch
        4 kB
        Christian Carlow

        Issue Links

          Activity

          Hide
          ofbizzer Christian Carlow added a comment -

          This patch was extracted from OFBIZ-6085 to handle this issue separately.

          Show
          ofbizzer Christian Carlow added a comment - This patch was extracted from OFBIZ-6085 to handle this issue separately.
          Hide
          pandeypranay Pranay Pandey added a comment -

          Hi Christian Carlow,

          I reviewed this patch and found it good. Could you please also check unit test - testCreateProductionRunForOrder for the same. It's failing as now and it's a good chance to correct it.

          Show
          pandeypranay Pranay Pandey added a comment - Hi Christian Carlow , I reviewed this patch and found it good. Could you please also check unit test - testCreateProductionRunForOrder for the same. It's failing as now and it's a good chance to correct it.
          Hide
          pandeypranay Pranay Pandey added a comment -

          Okay, checked it again, test suite productionruntests running fine, all tests passed.
          Here is the result:

          Results for test suite: productionruntests
          Pass: true | # Tests: 35 | # Failed: 0 # Errors: 0
          

          Going to commit the fix.

          Show
          pandeypranay Pranay Pandey added a comment - Okay, checked it again, test suite productionruntests running fine, all tests passed. Here is the result: Results for test suite: productionruntests Pass: true | # Tests: 35 | # Failed: 0 # Errors: 0 Going to commit the fix.
          Hide
          pandeypranay Pranay Pandey added a comment -

          Thanks Christian Carlow for the contribution.

          Patch committed to trunk at r1748387.

          Show
          pandeypranay Pranay Pandey added a comment - Thanks Christian Carlow for the contribution. Patch committed to trunk at r1748387.

            People

            • Assignee:
              pandeypranay Pranay Pandey
              Reporter:
              ofbizzer Christian Carlow
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development