Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: None
    • Fix Version/s: Trunk, 16.11.01
    • Component/s: ALL COMPONENTS
    • Labels:
      None
    • Sprint:
      Bug Crush Event - 21/2/2015, Community Day 1 - 2016

      Description

      I don't see a need for menus, but could be. Relates also to OFBIZ-6034

      1. OFBIZ-6327.patch
        21 kB
        Nicolas Malin
      2. OFBIZ-6327.patch
        20 kB
        Nicolas Malin

        Activity

        Hide
        soledad Nicolas Malin added a comment -

        I will need call modal screen from form link and menu to improve quote screen ! So

        But I propose to rename the link-type : ajax-window to modal

        Show
        soledad Nicolas Malin added a comment - I will need call modal screen from form link and menu to improve quote screen ! So But I propose to rename the link-type : ajax-window to modal
        Hide
        pfm.smits Pierre Smits added a comment -

        That would indeed be a better name as it is in line with what other frameworks/techniques use.

        Show
        pfm.smits Pierre Smits added a comment - That would indeed be a better name as it is in line with what other frameworks/techniques use.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I'd suggest layered-modal BTW we spoke about that at OFBIZ-4183 so we could close it after IMO

        Also while at it you might consider OFBIZ-6359

        Show
        jacques.le.roux Jacques Le Roux added a comment - I'd suggest layered-modal BTW we spoke about that at OFBIZ-4183 so we could close it after IMO Also while at it you might consider OFBIZ-6359
        Hide
        soledad Nicolas Malin added a comment -

        I'd suggest layered-modal

        Nice for me.

        I will try to close this issues for the next few days.

        Show
        soledad Nicolas Malin added a comment - I'd suggest layered-modal Nice for me. I will try to close this issues for the next few days.
        Hide
        soledad Nicolas Malin added a comment -

        I load a first version to manage layered-window in forms (and also in menus)

        I added default properties value for the width and height size.

        Feel free for remarks

        Show
        soledad Nicolas Malin added a comment - I load a first version to manage layered-window in forms (and also in menus) I added default properties value for the width and height size. Feel free for remarks
        Hide
        soledad Nicolas Malin added a comment -

        I reload my patch because it's a few strange!! It wasn't apply on trunk :/

        Show
        soledad Nicolas Malin added a comment - I reload my patch because it's a few strange!! It wasn't apply on trunk :/
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I checked they are the same (I still had the old one open) Both applies here on trunk HEAD

        Show
        jacques.le.roux Jacques Le Roux added a comment - I checked they are the same (I still had the old one open) Both applies here on trunk HEAD
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I will try it in a project where it will be easy to check...

        Show
        jacques.le.roux Jacques Le Roux added a comment - I will try it in a project where it will be easy to check...
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Ouch much conflicts, will see later...

        Show
        jacques.le.roux Jacques Le Roux added a comment - Ouch much conflicts, will see later...
        Hide
        soledad Nicolas Malin added a comment -

        Ahh

        mnicolas@meno:~/workspace/ofbiz-trunk-2$ patch -p0 < ~/Téléchargements/OFBIZ-6327.patch 
        patching file framework/widget/config/widget.properties
        patching file framework/widget/dtd/widget-common.xsd
        patching file framework/widget/src/org/ofbiz/widget/model/CommonWidgetModels.java
        patching file framework/widget/src/org/ofbiz/widget/renderer/macro/MacroFormRenderer.java
        patching file framework/widget/src/org/ofbiz/widget/renderer/macro/MacroMenuRenderer.java
        patching file framework/widget/src/org/ofbiz/widget/renderer/macro/MacroScreenRenderer.java
        patching file framework/widget/templates/htmlFormMacroLibrary.ftl
        patching file framework/widget/templates/htmlMenuMacroLibrary.ftl
        patching file framework/widget/templates/htmlScreenMacroLibrary.ftl
        patching file specialpurpose/example/widget/example/ExampleFeatureForms.xml
        patching file specialpurpose/example/widget/example/ExampleForms.xml
        patching file specialpurpose/example/widget/example/ExampleScreens.xml
        mnicolas@meno:~/workspace/ofbiz-trunk-2$ svn info
        Chemin : .
        Chemin racine de la copie de travail : /home/mnicolas/workspace/ofbiz-trunk-2
        URL : http://svn.apache.org/repos/asf/ofbiz/trunk
        Relative URL: ^/ofbiz/trunk
        Racine du dépôt : http://svn.apache.org/repos/asf
        UUID du dépôt : 13f79535-47bb-0310-9956-ffa450edef68
        Révision : 1706278
        Type de nœud : répertoire
        Tâche programmée : normale
        Auteur de la dernière modification : jleroux
        Révision de la dernière modification : 1706162
        
        Show
        soledad Nicolas Malin added a comment - Ahh mnicolas@meno:~/workspace/ofbiz-trunk-2$ patch -p0 < ~/Téléchargements/OFBIZ-6327.patch patching file framework/widget/config/widget.properties patching file framework/widget/dtd/widget-common.xsd patching file framework/widget/src/org/ofbiz/widget/model/CommonWidgetModels.java patching file framework/widget/src/org/ofbiz/widget/renderer/macro/MacroFormRenderer.java patching file framework/widget/src/org/ofbiz/widget/renderer/macro/MacroMenuRenderer.java patching file framework/widget/src/org/ofbiz/widget/renderer/macro/MacroScreenRenderer.java patching file framework/widget/templates/htmlFormMacroLibrary.ftl patching file framework/widget/templates/htmlMenuMacroLibrary.ftl patching file framework/widget/templates/htmlScreenMacroLibrary.ftl patching file specialpurpose/example/widget/example/ExampleFeatureForms.xml patching file specialpurpose/example/widget/example/ExampleForms.xml patching file specialpurpose/example/widget/example/ExampleScreens.xml mnicolas@meno:~/workspace/ofbiz-trunk-2$ svn info Chemin : . Chemin racine de la copie de travail : /home/mnicolas/workspace/ofbiz-trunk-2 URL : http: //svn.apache.org/repos/asf/ofbiz/trunk Relative URL: ^/ofbiz/trunk Racine du dépôt : http: //svn.apache.org/repos/asf UUID du dépôt : 13f79535-47bb-0310-9956-ffa450edef68 Révision : 1706278 Type de nœud : répertoire Tâche programmée : normale Auteur de la dernière modification : jleroux Révision de la dernière modification : 1706162
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        To be honest, once again I was caught by Jira not pushing updates on changes. So I did not see your last patch. But anyway the only real change in it is the documentation added in widget-common.xsd

        Show
        jacques.le.roux Jacques Le Roux added a comment - To be honest, once again I was caught by Jira not pushing updates on changes. So I did not see your last patch. But anyway the only real change in it is the documentation added in widget-common.xsd
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        It works for me and I'm quite happy with it. There is just one thing I was unable to do: make the link as a button (using buttontext style). I wanted to add an example inside FormWidgetExampleForms.xml

        Index: FormWidgetExampleForms.xml
        ===================================================================
        --- FormWidgetExampleForms.xml	(revision 1705973)
        +++ FormWidgetExampleForms.xml	(working copy)
        @@ -231,6 +231,15 @@
                         </entity-options>
                     </drop-down>
                 </field>
        +        
        +        <!-- ************************ -->
        +        <!-- ***   Layered-modal  *** -->
        +        <!-- ************************ -->
        +        <field name="emptyField0" title=" "><display/></field>
        +        <field name="newExample" title=" " widget-style="buttontext">
        +            <hyperlink also-hidden="false" description="${uiLabelMap.ExampleNewExample}" target="EditExampleLayer" link-type="layered-modal"/>
        +        </field>
        +        
        

        I did not digg further in code than MacroFormRenderer.java. I guess we can do something from there though I wonder why linkStyle is no applied. I will maybe get back to it later...

        Show
        jacques.le.roux Jacques Le Roux added a comment - It works for me and I'm quite happy with it. There is just one thing I was unable to do: make the link as a button (using buttontext style). I wanted to add an example inside FormWidgetExampleForms.xml Index: FormWidgetExampleForms.xml =================================================================== --- FormWidgetExampleForms.xml (revision 1705973) +++ FormWidgetExampleForms.xml (working copy) @@ -231,6 +231,15 @@ </entity-options> </drop-down> </field> + + <!-- ************************ --> + <!-- *** Layered-modal *** --> + <!-- ************************ --> + <field name= "emptyField0" title= " " ><display/></field> + <field name= "newExample" title= " " widget-style= "buttontext" > + <hyperlink also-hidden= " false " description= "${uiLabelMap.ExampleNewExample}" target= "EditExampleLayer" link-type= "layered-modal" /> + </field> + I did not digg further in code than MacroFormRenderer.java. I guess we can do something from there though I wonder why linkStyle is no applied. I will maybe get back to it later...
        Hide
        soledad Nicolas Malin added a comment -

        Yes sure jacques it's good idea.

        I haven't my commit environment on my laptop but I would be commit this after the apachecon EU

        Show
        soledad Nicolas Malin added a comment - Yes sure jacques it's good idea. I haven't my commit environment on my laptop but I would be commit this after the apachecon EU
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Nicolas

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Nicolas
        Hide
        soledad Nicolas Malin added a comment -

        Ok it's now in trunk at rev 1706909.

        Show
        soledad Nicolas Malin added a comment - Ok it's now in trunk at rev 1706909.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks NIcolas! I wrill try to find a way to have a button there

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks NIcolas! I wrill try to find a way to have a button there
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Got one at revision: 1707949, but not completly satisfying

        Show
        jacques.le.roux Jacques Le Roux added a comment - Got one at revision: 1707949, but not completly satisfying

          People

          • Assignee:
            soledad Nicolas Malin
            Reporter:
            jacques.le.roux Jacques Le Roux
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile