Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6302

Ftl to Widget: improve ViewCertificate to use widgets instead of ftl

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: framework
    • Labels:

      Description

      Currently the screen ViewCertificate uses a freemarker to render the form(s). This can be replaced by widgets

      1. OFBIZ-6302-Certificate.patch
        10 kB
        Pierre Smits
      2. OFBIZ-6302-Certificate.patch
        15 kB
        Jacques Le Roux

        Activity

        Hide
        pfm.smits Pierre Smits added a comment -

        This patch addresses the issue.

        Show
        pfm.smits Pierre Smits added a comment - This patch addresses the issue.
        Hide
        pfm.smits Pierre Smits added a comment -

        Bump. Can we have this implemented before the patch grows stale?

        Show
        pfm.smits Pierre Smits added a comment - Bump. Can we have this implemented before the patch grows stale?
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        The patch is already too old, but I think it's only paths changes to apply

        Show
        jacques.le.roux Jacques Le Roux added a comment - The patch is already too old, but I think it's only paths changes to apply
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Hi Pierre,

        Here is the patch updated. I fixed things by hand: tabs in the groovy files and removed the ftl file because of a tree conflicts due to the recent ftl files move.

        I let you test because I did not find where this is used. I found the ViewCertificate and importIssuerProvision requests but they are all in common stuff so I did not know how to relate it to a webapp. Also there is still a ViewCertificate.ftl in party but it does not seem to be used

        Show
        jacques.le.roux Jacques Le Roux added a comment - Hi Pierre, Here is the patch updated. I fixed things by hand: tabs in the groovy files and removed the ftl file because of a tree conflicts due to the recent ftl files move. I let you test because I did not find where this is used. I found the ViewCertificate and importIssuerProvision requests but they are all in common stuff so I did not know how to relate it to a webapp. Also there is still a ViewCertificate.ftl in party but it does not seem to be used
        Hide
        pfm.smits Pierre Smits added a comment - - edited

        [~jacques le roux] DevOps functionalities are - unfortunately - all over the place. We have them in webtools, common and partymgr.

        Show
        pfm.smits Pierre Smits added a comment - - edited [~jacques le roux] DevOps functionalities are - unfortunately - all over the place. We have them in webtools, common and partymgr.
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        I compared the 2 ViewCertificate.ftl, they are almost the same. At least 1 will be gone. I made a small mistake in my patch (added commons-safe-head.ftl which is a long pending and should not be there). Anyway, I was ready to commit when we got issues in BuildBot, HW team is investigating...

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited I compared the 2 ViewCertificate.ftl, they are almost the same. At least 1 will be gone. I made a small mistake in my patch (added commons-safe-head.ftl which is a long pending and should not be there). Anyway, I was ready to commit when we got issues in BuildBot, HW team is investigating...
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Pierre,

        Your modified patch is in trunk at revision: 1753024

        I updated the patch. I fixed things by hand: tabs in the groovy files, removed the ftl file because of a tree conflicts due to the recent ftl files move and updated org.ofbiz to org.apache.ofbiz in CertKeystore.groovy

        I don't close to let you check all is allright before closing, thanks!

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Pierre, Your modified patch is in trunk at revision: 1753024 I updated the patch. I fixed things by hand: tabs in the groovy files, removed the ftl file because of a tree conflicts due to the recent ftl files move and updated org.ofbiz to org.apache.ofbiz in CertKeystore.groovy I don't close to let you check all is allright before closing, thanks!

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            pfm.smits Pierre Smits
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development