Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6229

Can't create a geo without providing a geoID

    Details

      Description

      Currently the process of creating a geo fails when a geoId is not provided. The process should self-provide the geoId if it isn't provided by the user.

        Activity

        Hide
        taher Taher Alkhateeb added a comment - - edited

        This issue triggered multiple other issues that I noticed in the geo management forms as follows:

        • The search screen results take you to the link geos. I believe it should go directly to create / edit instead
        • You cannot edit a geo because the parameter is not passed across the tabs link and edit / create. The menus should be redefined to pass the parameter around
        • The primary key is enforced in the service definition when it should be optional to create new geos
        • finally, the geoId should not be a lookup field. An entity cannot lookup itself

        I will apply a commit to fix all the above

        Show
        taher Taher Alkhateeb added a comment - - edited This issue triggered multiple other issues that I noticed in the geo management forms as follows: The search screen results take you to the link geos. I believe it should go directly to create / edit instead You cannot edit a geo because the parameter is not passed across the tabs link and edit / create. The menus should be redefined to pass the parameter around The primary key is enforced in the service definition when it should be optional to create new geos finally, the geoId should not be a lookup field. An entity cannot lookup itself I will apply a commit to fix all the above
        Hide
        taher Taher Alkhateeb added a comment -

        fixed in r1682415

        Show
        taher Taher Alkhateeb added a comment - fixed in r1682415
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Pierre, Taher,

        After r1682444 where I commited

        "Replaces by better labels, stumbled upon it while backporting r1682415 for OFBIZ-6229. I missed it when committing r1667969"

        I backported to
        R14.12 at r1682445
        R13.07 at r1682446
        R12.04 at r1682447

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Pierre, Taher, After r1682444 where I commited "Replaces by better labels, stumbled upon it while backporting r1682415 for OFBIZ-6229 . I missed it when committing r1667969" I backported to R14.12 at r1682445 R13.07 at r1682446 R12.04 at r1682447
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Taher, I just changed it for you: you fix only unreleased versions, so it's not trunk to put in "Fix Version/s" field but "Upcoming Branch". We use that to automatically generate releases changelogs from Jira, thank!

        Show
        jacques.le.roux Jacques Le Roux added a comment - Taher, I just changed it for you: you fix only unreleased versions, so it's not trunk to put in "Fix Version/s" field but "Upcoming Branch". We use that to automatically generate releases changelogs from Jira, thank!
        Hide
        taher Taher Alkhateeb added a comment -

        Thank you Jacques, next time I will make sure to label it as "Upcoming Branch".

        How do you link the commit to the JIRA? or does it happen automatically if you put the HTML link to the JIRA in the commit message?

        Show
        taher Taher Alkhateeb added a comment - Thank you Jacques, next time I will make sure to label it as "Upcoming Branch". How do you link the commit to the JIRA? or does it happen automatically if you put the HTML link to the JIRA in the commit message?
        Hide
        pfm.smits Pierre Smits added a comment -

        Thanks Taher and Jacques.

        Show
        pfm.smits Pierre Smits added a comment - Thanks Taher and Jacques.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Putting the OFBIZ-#### ref as you did for r1682415 is enough. I often put the complete URL, most env allow you to simply click then to get there. It's also good to put a word about the contributor (the person who reported/created the Jira), even id this person did not provide a patch. Remember you can always update svn commits comments

        Show
        jacques.le.roux Jacques Le Roux added a comment - Putting the OFBIZ-#### ref as you did for r1682415 is enough. I often put the complete URL, most env allow you to simply click then to get there. It's also good to put a word about the contributor (the person who reported/created the Jira), even id this person did not provide a patch. Remember you can always update svn commits comments
        Hide
        taher Taher Alkhateeb added a comment -

        Thank you Jacques for the feedback. For the record this was my first commit so I was a bit terrified and I can now release a sigh of relief.

        Who should close this issue and when? Is it Pierre as the reporter or is it when someone validates with a test (I tested already)? And when should it be closed, does some time have to pass?

        Show
        taher Taher Alkhateeb added a comment - Thank you Jacques for the feedback. For the record this was my first commit so I was a bit terrified and I can now release a sigh of relief. Who should close this issue and when? Is it Pierre as the reporter or is it when someone validates with a test (I tested already)? And when should it be closed, does some time have to pass?
        Hide
        pfm.smits Pierre Smits added a comment -

        I will close this issue.

        Show
        pfm.smits Pierre Smits added a comment - I will close this issue.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Actually it depends on the issue. If it's a big or complicated one better to wait the reporter to close. But most of the time you can close yourself, notably if the reporter forget, after some time. BTW did you read: https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-CommittingChanges ?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Actually it depends on the issue. If it's a big or complicated one better to wait the reporter to close. But most of the time you can close yourself, notably if the reporter forget, after some time. BTW did you read: https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-CommittingChanges ?

          People

          • Assignee:
            taher Taher Alkhateeb
            Reporter:
            pfm.smits Pierre Smits
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development