Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6144

Convert FindShipment ftl to form widget

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Resolved
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: product
    • Labels:
      None

      Description

      The error below occurs when findShipmentExprs is null in FindShipment.groovy which prevents the page from even displaying. IMO the FindShipment.groovy and FindShipment.ftl should be replaced with form widgets.

      ERROR rendering error page [/error/error.jsp], but here is the error text: org.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen component://product/widget/facility/ShipmentScreens.xml#FindShipment: java.lang.IllegalArgumentException: Error running script at location [component://product/webapp/facility/WEB-INF/actions/shipment/FindShipment.groovy]: groovy.lang.GroovyRuntimeException: Ambiguous method overloading for method org.ofbiz.entity.util.EntityQuery#where. Cannot resolve which method to invoke for [null] due to overlapping prototypes between: [interface java.util.List] [interface java.util.Map] (Error running script at location [component://product/webapp/facility/WEB-INF/actions/shipment/FindShipment.groovy]: groovy.lang.GroovyRuntimeException: Ambiguous method overloading for method org.ofbiz.entity.util.EntityQuery#where. Cannot resolve which method to invoke for [null] due to overlapping prototypes between: [interface java.util.List] [interface java.util.Map])

      1. OFBIZ-6144.patch
        7 kB
        Pawan Verma
      2. OFBIZ-6144.patch
        7 kB
        Christian Carlow

        Issue Links

          Activity

          Hide
          ofbizzer Christian Carlow added a comment -

          FindShipment.groovy used to have a check to make sure findShipmentExprs existed before performing the query at line 135.

          Show
          ofbizzer Christian Carlow added a comment - FindShipment.groovy used to have a check to make sure findShipmentExprs existed before performing the query at line 135.
          Hide
          ofbizzer Christian Carlow added a comment -

          This patch replaces FindShipment.groovy and FindShipment.ftl with form widgets. The two files can probably be removed once this patch is applied.

          Show
          ofbizzer Christian Carlow added a comment - This patch replaces FindShipment.groovy and FindShipment.ftl with form widgets. The two files can probably be removed once this patch is applied.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          An URL and/or steps to get there is always welcome, easier to reproduce and test

          Show
          jacques.le.roux Jacques Le Roux added a comment - An URL and/or steps to get there is always welcome, easier to reproduce and test
          Hide
          ofbizzer Christian Carlow added a comment -
          Show
          ofbizzer Christian Carlow added a comment - https://192.168.1.24:8444/facility/control/FindShipment (Facility->Shipment)
          Hide
          deepak.dixit Deepak Dixit added a comment -

          NPE issue already fixed under OFBIZ-6058, Its an good idea to convert ftl into form widget.
          I am converting this issue type to improvement as conversion form ftl to form widget is an improvement.

          Show
          deepak.dixit Deepak Dixit added a comment - NPE issue already fixed under OFBIZ-6058 , Its an good idea to convert ftl into form widget. I am converting this issue type to improvement as conversion form ftl to form widget is an improvement.
          Hide
          pawan.verma Pawan Verma added a comment -

          Here is the updated patch for this improvement. There are some conflicts in ShipmentScreens.xml file from the previous patch, I have fixed this manually and done testing on this improvement.

          Show
          pawan.verma Pawan Verma added a comment - Here is the updated patch for this improvement. There are some conflicts in ShipmentScreens.xml file from the previous patch, I have fixed this manually and done testing on this improvement.
          Hide
          pfm.smits Pierre Smits added a comment -

          I guess that the previous patch file became stale.

          Show
          pfm.smits Pierre Smits added a comment - I guess that the previous patch file became stale.
          Hide
          deepak.dixit Deepak Dixit added a comment -

          This has been committed at trunk at r#1750240

          Thanks Christian Carlow and Pawan for your contribution.

          Show
          deepak.dixit Deepak Dixit added a comment - This has been committed at trunk at r#1750240 Thanks Christian Carlow and Pawan for your contribution.

            People

            • Assignee:
              deepak.dixit Deepak Dixit
              Reporter:
              ofbizzer Christian Carlow
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development