Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6016

Adding som Dutch translations to common labels.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: framework
    • Labels:
      None

      Activity

      Hide
      pfm.smits Pierre Smits added a comment -

      This patch addresses the issue.

      Show
      pfm.smits Pierre Smits added a comment - This patch addresses the issue.
      Hide
      jacques.le.roux Jacques Le Roux added a comment -

      Thanks Pierre,

      Your modified patch is in trunk at r1653143

      I had though to fix some issues:
      I removed
      3 specific comments
      <!-- ORRTIZ: TAXREPORT -->
      <!-- GEO -->
      <!-- ORRTIZ:BMS Applications -->
      2 duplicates
      <value xml:lang="nl">Gesynchroniseerd</value>
      <value xml:lang="nl">Req. - geannuleerd</value>
      For the later I kept the old one which seems more complete

      I replaced 2482 <value xml:lang="(.)_(.)"> by <value xml:lang="(.)-(.)">
      Please no longer use "_" but "-" there thanks!

      Show
      jacques.le.roux Jacques Le Roux added a comment - Thanks Pierre, Your modified patch is in trunk at r1653143 I had though to fix some issues: I removed 3 specific comments <!-- ORRTIZ: TAXREPORT --> <!-- GEO --> <!-- ORRTIZ:BMS Applications --> 2 duplicates <value xml:lang="nl">Gesynchroniseerd</value> <value xml:lang="nl">Req. - geannuleerd</value> For the later I kept the old one which seems more complete I replaced 2482 <value xml:lang="(. )_(. )"> by <value xml:lang="(. )-(. )"> Please no longer use "_" but "-" there thanks!
      Hide
      pfm.smits Pierre Smits added a comment -

      Darn. What a nuisance. I did a cursory check on the CommonUiLabels before I generated the patch as I had a number of merge conflicts on pt-BR. So I corrected the merge conflicts and the IDE gave the OK. And I submitted the patch. Didn't see it coming that there were still other _ translations in the file, otherwise I would have corrected those too.

      I will check https://issues.apache.org/jira/browse/OFBIZ-6018 and https://issues.apache.org/jira/browse/OFBIZ-6019 again.

      Show
      pfm.smits Pierre Smits added a comment - Darn. What a nuisance. I did a cursory check on the CommonUiLabels before I generated the patch as I had a number of merge conflicts on pt-BR. So I corrected the merge conflicts and the IDE gave the OK. And I submitted the patch. Didn't see it coming that there were still other _ translations in the file, otherwise I would have corrected those too. I will check https://issues.apache.org/jira/browse/OFBIZ-6018 and https://issues.apache.org/jira/browse/OFBIZ-6019 again.
      Hide
      pfm.smits Pierre Smits added a comment -

      Reopening as quite some ORRTIZ specific labels accidentally slipped into the previous patch.

      Show
      pfm.smits Pierre Smits added a comment - Reopening as quite some ORRTIZ specific labels accidentally slipped into the previous patch.
      Hide
      pfm.smits Pierre Smits added a comment -

      This patch addresses the issue of the accidental slipped in labels.

      Show
      pfm.smits Pierre Smits added a comment - This patch addresses the issue of the accidental slipped in labels.
      Hide
      jacques.le.roux Jacques Le Roux added a comment -

      This patch does not apply.

      We have not the <!-- ORRTIZ:BMS Applications --> block in OFBiz
      Nor <property key="Enumeration.description.TX_D_PROD">
      And globally I see no reasons in your changes.
      You must have an issue locally please check an close if OK

      Show
      jacques.le.roux Jacques Le Roux added a comment - This patch does not apply. We have not the <!-- ORRTIZ:BMS Applications --> block in OFBiz Nor <property key="Enumeration.description.TX_D_PROD"> And globally I see no reasons in your changes. You must have an issue locally please check an close if OK
      Hide
      pfm.smits Pierre Smits added a comment -
      Show
      pfm.smits Pierre Smits added a comment - Please check again with http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/config/CommonUiLabels.xml?view=markup Shows ORRTIZ specifics at the bottom.
      Hide
      jacques.le.roux Jacques Le Roux added a comment -

      Thanks Pierre,

      Your last patch is in trunk at revision: 1653224

      I forgot to svn up after chasing Adrian's bug at r1652638

      Show
      jacques.le.roux Jacques Le Roux added a comment - Thanks Pierre, Your last patch is in trunk at revision: 1653224 I forgot to svn up after chasing Adrian's bug at r1652638

        People

        • Assignee:
          pfm.smits Pierre Smits
          Reporter:
          pfm.smits Pierre Smits
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development