Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-5975

Form ViewSprintItem is not referenced in screens

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: scrum
    • Labels:
    • Sprint:
      Bug Crush Event - 21/2/2015

      Description

      The form exists, but isn't referenced in a screen in Scrum.

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Definitively removed at revision: 1685621

        Show
        jacques.le.roux Jacques Le Roux added a comment - Definitively removed at revision: 1685621
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        I thought the same while commiting "if the committer wants to continue he can use the repository as backup". Then decided to let him a chance for a week and let him reopen. Better indeed to let open and close in week by removing unused stuff...I reopen... I guess the interested persons should have now enough signals to decide...

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited I thought the same while commiting "if the committer wants to continue he can use the repository as backup". Then decided to let him a chance for a week and let him reopen. Better indeed to let open and close in week by removing unused stuff...I reopen... I guess the interested persons should have now enough signals to decide...
        Hide
        pfm.smits Pierre Smits added a comment -

        Closing this issue seems to be premature. The patch is only implemented partially and unused code remains in the repository. Furthermore, the issue exists since January 16th, and it seems to me that the original contributor has had ample time to state his concerns...

        This patch could have easily been implemented completely.... The part left out, and now commented out in the repository, can easily be reintroduced based on (newly identified) requirements.

        Show
        pfm.smits Pierre Smits added a comment - Closing this issue seems to be premature. The patch is only implemented partially and unused code remains in the repository. Furthermore, the issue exists since January 16th, and it seems to me that the original contributor has had ample time to state his concerns... This patch could have easily been implemented completely.... The part left out, and now commented out in the repository, can easily be reintroduced based on (newly identified) requirements.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Pierre,

        Before you attached your patch I had already committed one where I rather commented out the lines related to the ViewSprintItem lines in case the original author decides to use it.

        I have committed the rest of your patch at revision: 1684128, both patches only in trunk.

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Pierre, Before you attached your patch I had already committed one where I rather commented out the lines related to the ViewSprintItem lines in case the original author decides to use it. I have committed the rest of your patch at revision: 1684128, both patches only in trunk.
        Hide
        pfm.smits Pierre Smits added a comment -

        This patch removes the unused form. It also adds the request-confirmation element to the hyperlink contained in various 'deleteLink' fields.

        Show
        pfm.smits Pierre Smits added a comment - This patch removes the unused form. It also adds the request-confirmation element to the hyperlink contained in various 'deleteLink' fields.

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            pfm.smits Pierre Smits
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile