Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-5962

If orderDecimalQuantity set to N then system should return error if user add partial quantity in order

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Release Branch 13.07, Trunk, 14.12.01
    • Fix Version/s: 14.12.01, 13.07.02, 16.11.01
    • Component/s: order
    • Labels:
      None
    • Sprint:
      Bug Crush Event - 21/2/2015

      Description

      If productStore.orderDecimalQuantity and product.orderDecimalQuantity is set to N, then system should return error if we try to add to partial quantity then system should return error instead of rounding it to 0,

      Actual Behavior: If partial quantity not allowed in in order process, and user enter 1.5 quantity then it rounded it and add 2 quantity.

      Expected Behavior: if partial quantity not allowed then system should return error instead of doing rounding if partial quantity passed during add/update item.

      1. OFBIZ-5962-1307.patch
        13 kB
        Deepak Dixit
      2. OFBIZ-5962-TRUNK.patch
        13 kB
        Deepak Dixit

        Issue Links

          Activity

          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Hi Deepak, will you provide a patch?

          Show
          jacques.le.roux Jacques Le Roux added a comment - Hi Deepak, will you provide a patch?
          Hide
          deepak.dixit Deepak Dixit added a comment -

          Yes Jacques, I'll upload a patch for this issue.

          Show
          deepak.dixit Deepak Dixit added a comment - Yes Jacques, I'll upload a patch for this issue.
          Hide
          deepak.dixit Deepak Dixit added a comment - - edited

          While fixing this issue found that orderDecimalQuantity check is missing while add item to order and update order item flow. I'll add these check as well for add item and update order flow.

          Show
          deepak.dixit Deepak Dixit added a comment - - edited While fixing this issue found that orderDecimalQuantity check is missing while add item to order and update order item flow. I'll add these check as well for add item and update order flow.
          Hide
          deepak.dixit Deepak Dixit added a comment -

          Hi Jacques,

          Here is the patch for this issue.

          Show
          deepak.dixit Deepak Dixit added a comment - Hi Jacques, Here is the patch for this issue.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks for the 2 patches Deepak!

          Your patches are in
          trunk r1661862
          R14.12 r1661863
          R13.07 r1661864

          r1661864 did not merge in R12

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks for the 2 patches Deepak! Your patches are in trunk r1661862 R14.12 r1661863 R13.07 r1661864 r1661864 did not merge in R12
          Hide
          deepak.dixit Deepak Dixit added a comment -

          Thanks Jacques.

          Show
          deepak.dixit Deepak Dixit added a comment - Thanks Jacques.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Ha Deepak,

          It's not

          If productStore.orderDecimalQuantity and product.orderDecimalQuantity is set to N, then system should return error if we try to add to partial quantity then system should return error instead of rounding it to 0

          but

          If productStore.orderDecimalQuantity OR product.orderDecimalQuantity is set to N, then system should return error if we try to add to partial quantity then system should return error instead of rounding it to 0

          Show
          jacques.le.roux Jacques Le Roux added a comment - Ha Deepak, It's not If productStore.orderDecimalQuantity and product.orderDecimalQuantity is set to N, then system should return error if we try to add to partial quantity then system should return error instead of rounding it to 0 but If productStore.orderDecimalQuantity OR product.orderDecimalQuantity is set to N, then system should return error if we try to add to partial quantity then system should return error instead of rounding it to 0

            People

            • Assignee:
              jacques.le.roux Jacques Le Roux
              Reporter:
              deepak.dixit Deepak Dixit
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile