Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-5893

Use EntityQuery Builder methods in goovy files by replacing Entity Engine methods.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 14.12.01, 16.11.01
    • Component/s: None
    • Labels:
      None
    • Sprint:
      Bug Crush Event - 21/2/2015

      Description

      Recently Jacopo Cappellato has added to the OFBiz DSL the ability to invoke new EntityQuery builder in groovy files at r1638054.

      Replace entity engine methods in groovy files with EntityQuery builder methods.

      Already replaced in java files, see details in jira task OFBIZ-5844

      1. OFBIZ-5893-accounting.patch
        97 kB
        Arun Patidar
      2. OFBIZ-5893-content.patch
        20 kB
        Arun Patidar
      3. OFBIZ-5893-fix.patch
        1 kB
        Arun Patidar
      4. OFBIZ-5893-hr-manufact-marketing.patch
        64 kB
        Arun Patidar
      5. OFBIZ-5893-order.patch
        127 kB
        Arun Patidar
      6. OFBIZ-5893-partyNworkEffort.patch
        27 kB
        Arun Patidar
      7. OFBIZ-5893-Product.patch
        137 kB
        Arun Patidar
      8. OFBIZ-5893-SpecialPurpose.patch
        188 kB
        Arun Patidar

        Issue Links

          Activity

          Hide
          arunpati Arun Patidar added a comment -

          Attached is the patch with use of EntityQuery builder methods in groovy file of accounting component.

          Show
          arunpati Arun Patidar added a comment - Attached is the patch with use of EntityQuery builder methods in groovy file of accounting component.
          Hide
          arunpati Arun Patidar added a comment -

          Attached is the patch for using EntityQuery builder methods in groovy files of content component.

          Show
          arunpati Arun Patidar added a comment - Attached is the patch for using EntityQuery builder methods in groovy files of content component.
          Hide
          arunpati Arun Patidar added a comment -

          Attached is a patch for order component.

          Show
          arunpati Arun Patidar added a comment - Attached is a patch for order component.
          Hide
          arunpati Arun Patidar added a comment -

          Attached is a patch of HR, manufacturing and marking components.

          Show
          arunpati Arun Patidar added a comment - Attached is a patch of HR, manufacturing and marking components.
          Hide
          toashishvijay Ashish Vijaywargiya added a comment -

          Thanks Arun, I have committed all the patch files in trunk at r1646916

          Show
          toashishvijay Ashish Vijaywargiya added a comment - Thanks Arun, I have committed all the patch files in trunk at r1646916
          Hide
          arunpati Arun Patidar added a comment -

          Thanks Ashish for committing the patches. Attached is a patch for Party and WorkEffort component.

          Show
          arunpati Arun Patidar added a comment - Thanks Ashish for committing the patches. Attached is a patch for Party and WorkEffort component.
          Hide
          toashishvijay Ashish Vijaywargiya added a comment -

          Thanks Arun, Recent patch committed in trunk at r1647310.

          Show
          toashishvijay Ashish Vijaywargiya added a comment - Thanks Arun, Recent patch committed in trunk at r1647310.
          Hide
          arunpati Arun Patidar added a comment - - edited

          Attached is a patch to fix a typo in EntityQuery. Also imported missing Debug class.

          Show
          arunpati Arun Patidar added a comment - - edited Attached is a patch to fix a typo in EntityQuery. Also imported missing Debug class.
          Hide
          arunpati Arun Patidar added a comment -

          Attached are the patches from Product and SpecialPurpose components.I have done with all replacements in groovy files.

          I am keeping framework groovy files untouched with this replacement to keep references of EntityEngine methods.

          After committing these patches, this task can be close.

          Show
          arunpati Arun Patidar added a comment - Attached are the patches from Product and SpecialPurpose components.I have done with all replacements in groovy files. I am keeping framework groovy files untouched with this replacement to keep references of EntityEngine methods. After committing these patches, this task can be close.
          Hide
          toashishvijay Ashish Vijaywargiya added a comment -

          Thanks Arun, Done at r1647935.

          Show
          toashishvijay Ashish Vijaywargiya added a comment - Thanks Arun, Done at r1647935.
          Hide
          toashishvijay Ashish Vijaywargiya added a comment -

          Thanks Arun for product and specialpurpose contribution. Your changes are committed in trunk at r1647937

          Show
          toashishvijay Ashish Vijaywargiya added a comment - Thanks Arun for product and specialpurpose contribution. Your changes are committed in trunk at r1647937
          Hide
          komdata Sebastian Wachinger added a comment -

          Now we have the issue that it is no longer possible to set up, edit or delete Payment Settings for PayPal on catalog/control/EditProductStorePaySetup?productStoreId=9000
          These actions render a lengthy error message referring to applications/product/webapp/catalog/WEB-INF/actions/store/EditProductStorePaySetup.groovy ending with

          Cannot resolve which method to invoke for [null] due to overlapping prototypes between: [interface java.util.List] [interface java.util.Map])

          As a quick fix we had to revert from revision 1647937 to be able to set up payment settings for PayPal.

          Show
          komdata Sebastian Wachinger added a comment - Now we have the issue that it is no longer possible to set up, edit or delete Payment Settings for PayPal on catalog/control/EditProductStorePaySetup?productStoreId=9000 These actions render a lengthy error message referring to applications/product/webapp/catalog/WEB-INF/actions/store/EditProductStorePaySetup.groovy ending with Cannot resolve which method to invoke for [null] due to overlapping prototypes between: [interface java.util.List] [interface java.util.Map] ) As a quick fix we had to revert from revision 1647937 to be able to set up payment settings for PayPal.
          Hide
          komdata Sebastian Wachinger added a comment -

          Instantly fixed by Arun and Ashish in revision 1665198 and successfully tested by me

          Show
          komdata Sebastian Wachinger added a comment - Instantly fixed by Arun and Ashish in revision 1665198 and successfully tested by me
          Hide
          jacques.le.roux Jacques Le Roux added a comment - - edited

          Backported in R14.12 at r1665200

          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited Backported in R14.12 at r1665200

            People

            • Assignee:
              toashishvijay Ashish Vijaywargiya
              Reporter:
              arunpati Arun Patidar
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile