Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-5822

use requestParameters for customMethod call

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Release Branch 12.04, Release Branch 13.07, Trunk
    • Fix Version/s: Trunk, 12.04.06, 13.07.02
    • Component/s: content
    • Labels:
      None

      Description

      For a content, you can set a custom method that perform an action before content's rendering.

      Unfortunately, in the customMethod call, the request Parameters can't be used because they are not set into the map that is used to create custom method IN parameters.

      This patch solves this problem

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Pierre,

        I decided this was more a bug because it prevented to rightly use a custom method. So I backported in release branches

        Your patch is in
        trunk r1639606
        R13.07 r1639608
        R12.04 r1639609

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Pierre, I decided this was more a bug because it prevented to rightly use a custom method. So I backported in release branches Your patch is in trunk r1639606 R13.07 r1639608 R12.04 r1639609
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks to Scott's post on dev ML, improved in trunk at revision 1639887.

        I will wait to commit the last changes for the Poodle vulnerability (OFBIZ-5848) in release branches (for running tests with Java 1.7) before backporting, because I used the "new" diamond operator in r1639887.

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks to Scott's post on dev ML, improved in trunk at revision 1639887. I will wait to commit the last changes for the Poodle vulnerability ( OFBIZ-5848 ) in release branches (for running tests with Java 1.7) before backporting, because I used the "new" diamond operator in r1639887.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        R13.07 r1639987
        R12.04 r1639988

        Show
        jacques.le.roux Jacques Le Roux added a comment - R13.07 r1639987 R12.04 r1639988
        Hide
        gpierre Gaudin Pierre added a comment -

        Thanks Jacques !!

        Show
        gpierre Gaudin Pierre added a comment - Thanks Jacques !!
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        At r1639887 I forgot to put the content of templateContext in the local tempTemplateContext. Thanks to Deepak for spotting it. Fixed in
        trunk r1640717
        R13.07 r1640718
        R12.04 r1640719

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited At r1639887 I forgot to put the content of templateContext in the local tempTemplateContext. Thanks to Deepak for spotting it. Fixed in trunk r1640717 R13.07 r1640718 R12.04 r1640719

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            gpierre Gaudin Pierre
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development