Details

      Description

      After mounting ecommerce as root web app, I got ScreenRenderException, caused by StringIndexOutOfBoundsException: String index out of range: -1
      at org.ofbiz.product.category.CatalogUrlServlet.makeCatalogUrl(CatalogUrlServlet.java:186)

      Categories and products cannot be rendered.

      1. OFBIZ-5799.patch
        1 kB
        Josip Almasi
      2. OFBIZ-5799 - Can't mount root web app.patch
        4 kB
        Jacques Le Roux

        Activity

        Hide
        jalmasi Josip Almasi added a comment -

        Solves StringIndexOutOfBoundsException in CatalogUrlServlet.makeCatalogUrl() thrown for root context after mounting root web app.

        Show
        jalmasi Josip Almasi added a comment - Solves StringIndexOutOfBoundsException in CatalogUrlServlet.makeCatalogUrl() thrown for root context after mounting root web app.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Does this exist in trunk (we fix trunk and backport)?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Does this exist in trunk (we fix trunk and backport)?
        Hide
        jalmasi Josip Almasi added a comment -

        I don't know... just trying to get my shop running.

        Show
        jalmasi Josip Almasi added a comment - I don't know... just trying to get my shop running.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        OK I will check, thanks

        Show
        jacques.le.roux Jacques Le Roux added a comment - OK I will check, thanks
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I reproduced the bug in trunk and your patch fix it but there were other issues. The attached patch fix them, I will check later how this regression was introduced.

        BTW, if ever you are interested by SEO you might have a look at the http://svn.apache.org/viewvc/ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23/ branch. I will hopefully implement it in trunk later (see OFBIZ-5312)

        Show
        jacques.le.roux Jacques Le Roux added a comment - I reproduced the bug in trunk and your patch fix it but there were other issues. The attached patch fix them, I will check later how this regression was introduced. BTW, if ever you are interested by SEO you might have a look at the http://svn.apache.org/viewvc/ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23/ branch. I will hopefully implement it in trunk later (see OFBIZ-5312 )
        Hide
        jalmasi Josip Almasi added a comment -

        Sure I'm interested, thanks for info.
        But IMO ajax in category tree is major trouble, since it prevents all crawlers from getting the site content, can't even build sitemap.
        I'm about to rewrite that in ftl.

        Show
        jalmasi Josip Almasi added a comment - Sure I'm interested, thanks for info. But IMO ajax in category tree is major trouble, since it prevents all crawlers from getting the site content, can't even build sitemap. I'm about to rewrite that in ftl.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Are you speaking about Ajax categories tree in catalog applications? I agree about issues there, thought it's now better than it was at some point.

        I'm just passing so 2 things:

        • Before (IIRW in R11.04 maybe 10.04) it existed a non Ajax tree which was not bad (also in ecommerce if it's your point of interest)
        • See OFBIZ-4631
        Show
        jacques.le.roux Jacques Le Roux added a comment - Are you speaking about Ajax categories tree in catalog applications? I agree about issues there, thought it's now better than it was at some point. I'm just passing so 2 things: Before (IIRW in R11.04 maybe 10.04) it existed a non Ajax tree which was not bad (also in ecommerce if it's your point of interest) See OFBIZ-4631
        Hide
        jalmasi Josip Almasi added a comment -

        Thanks, that's what I'm talking about.
        And I think I found optimal solution - robot friendly AJAX tree:
        https://issues.apache.org/jira/browse/OFBIZ-5805

        Show
        jalmasi Josip Almasi added a comment - Thanks, that's what I'm talking about. And I think I found optimal solution - robot friendly AJAX tree: https://issues.apache.org/jira/browse/OFBIZ-5805
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        At this point, if you are interested in SEO (who's not?), I think I should mention OFBIZ-5312

        OK Just noticed I already mentionned it

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited At this point, if you are interested in SEO (who's not?), I think I should mention OFBIZ-5312 OK Just noticed I already mentionned it
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I just checked, you could not mount root web app in R4.0 but then until R11.04 (included) it was possible. So something happened between R11.04 and R12.04 and I don't want to get further. I will commit your enhanced patch!

        Show
        jacques.le.roux Jacques Le Roux added a comment - I just checked, you could not mount root web app in R4.0 but then until R11.04 (included) it was possible. So something happened between R11.04 and R12.04 and I don't want to get further. I will commit your enhanced patch!
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        Thanks Josip,

        Your patch (enhanced) has been committed in
        trunk r1631203
        R13.07 r1631204
        R12.04 r1631204

        It seems the 1st culprit commit is r1141878. WIth r1128983, another good reason for me to continue working on OFBIZ-5312 ...

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited Thanks Josip, Your patch (enhanced) has been committed in trunk r1631203 R13.07 r1631204 R12.04 r1631204 It seems the 1st culprit commit is r1141878 . WIth r1128983 , another good reason for me to continue working on OFBIZ-5312 ...

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            jalmasi Josip Almasi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development