[OFBIZ-5767] WebShoppingCart ignores session currency

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 12.04.04, 12.04.05
• Component/s: ecommerce
• Assignee: Jacques Le Roux
• Reporter: Josip Almasi
• Created: 11/Sep/14 10:15
• Updated: 16/Nov/18 10:02
• Resolved: 09/Jan/15 16:11

Description

This is how WebShoppingCart constructor calls ShoppingCart constructor:

(currencyUom != null ? currencyUom : ProductStoreWorker.getStoreCurrencyUomId(request)),

WebShoppingCart constructor is called only from

getCartObject(HttpServletRequest request, Locale locale, String currencyUom)

which is called only from

getCartObject(HttpServletRequest request)

with null locale and currency.
So, during WebShoppingCart creation, currency is always set to

ProductStoreWorker.getStoreCurrencyUomId(request)

This method in turn calls UtilHttp.getCurrencyUom(), which makes a number of attempts to find proper currency, with first attempt being session attribute "currencyUom".

This is a chicken-egg problem though: first-time user does not have currencyUom attribute set, and WebShoppingCart is created immediatelly.

But once created, nothing ever calls ShoppingCart.setCurrency()!
The bug is in ShoppingCartEvents.getCartObject():

if (cart == null)

{ cart = new WebShoppingCart(request, locale, currencyUom); session.setAttribute("shoppingCart", cart); }

else {
if (locale != null && !locale.equals(cart.getLocale()))

{ cart.setLocale(locale); }

if (currencyUom != null && !currencyUom.equals(cart.getCurrency())) {

Well, currencyUom parameter is always null.
If null, it needs to be taken from request parameter, or even better, to go thru entire UtilHttp.getCurrency() thing.

Issue Links

• relates to: OFBIZ-5765 missing request map for changing currency
• relates to: OFBIZ-4412 Set initial ecommerce Locale/Currency based on mount point specified in specialpurpose/ecommerce/ofbiz-component.xm
• mentioned in: Page Loading...