Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-5630

service updateFxConversion doesn't set thruDate properly

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Release Branch 11.04, Release Branch 12.04, Release Branch 13.07, Trunk
    • Fix Version/s: 14.12.01, 12.04.06, 13.07.02
    • Component/s: accounting
    • Labels:
      None

      Description

      When updating an existing foreign currency exchange rate in accounting the service creates a new exchange rate and sets the thruDate of the old rate.

      But in stead of taking the fromDate of the new exchange rate as a starting point for the thruDate of the expired exchange rate it uses nowTimeStamp.

      1. OFBIZ-5630.patch
        0.9 kB
        Pranay Pandey

        Activity

        Hide
        pandeypranay Pranay Pandey added a comment -

        Patch for the issue.

        Test scenarios -

        Go to ACCOUNTING > Global GL_Settings > Foreign Exchange Rates

        CASE 1: fromDate is provided by user

        I. under section 'Update Foreign Exchange Rates' provide the details for an existing exchange rate record

        a. for example consider EUR to USD conversion (demo record exists already)

        b. let us update this exchange rate by following steps :

        -choose EUR as 'From Currency' and USD as 'To Currency'

        -provide conversion rate, fromDate & thruDate(optional)

        -submit the form

        II. Expected Results:

        A new record should be created with above details & old record should have thruDate set same as fromDate of new record.

        CASE 2 : fromDate is not provided by user

        I. under section 'Update Foreign Exchange Rates' provide the details for an existing exchange rate record

        a. for example consider EUR to USD conversion (demo record exists already)

        b. let us update this exchange rate by following steps :

        -choose EUR as 'From Currency' and USD as 'To Currency'

        -provide conversion rate, thruDate(optional) & leave fromDate empty

        -submit the form

        II. Expected Results:

        A new record should be created with fromDate of new record & thruDate of old one set as 'current date time'.

        Show
        pandeypranay Pranay Pandey added a comment - Patch for the issue. Test scenarios - Go to ACCOUNTING > Global GL_Settings > Foreign Exchange Rates CASE 1: fromDate is provided by user I. under section 'Update Foreign Exchange Rates' provide the details for an existing exchange rate record a. for example consider EUR to USD conversion (demo record exists already) b. let us update this exchange rate by following steps : -choose EUR as 'From Currency' and USD as 'To Currency' -provide conversion rate, fromDate & thruDate(optional) -submit the form II. Expected Results: A new record should be created with above details & old record should have thruDate set same as fromDate of new record. CASE 2 : fromDate is not provided by user I. under section 'Update Foreign Exchange Rates' provide the details for an existing exchange rate record a. for example consider EUR to USD conversion (demo record exists already) b. let us update this exchange rate by following steps : -choose EUR as 'From Currency' and USD as 'To Currency' -provide conversion rate, thruDate(optional) & leave fromDate empty -submit the form II. Expected Results: A new record should be created with fromDate of new record & thruDate of old one set as 'current date time'.
        Hide
        toashishvijay Ashish Vijaywargiya added a comment -

        Thanks Pierre for reporting the issue. Thanks Pranay for providing the fix, changes are committed in trunk at r1639848 & in RB13.07 at r1639851 and in RB12.04 at r1639852.

        Show
        toashishvijay Ashish Vijaywargiya added a comment - Thanks Pierre for reporting the issue. Thanks Pranay for providing the fix, changes are committed in trunk at r1639848 & in RB13.07 at r1639851 and in RB12.04 at r1639852.

          People

          • Assignee:
            toashishvijay Ashish Vijaywargiya
            Reporter:
            pfm.smits Pierre Smits
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development