[OFBIZ-5578] Quick Ship Entire Order Never Shipping

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Release Branch 12.04, Trunk
• Fix Version/s: 11.04.05, 12.04.04, 14.12.01, 13.07.01
• Component/s: product
• Assignee: Jacopo Cappellato
• Reporter: Darrell Donati
• Created: 15/Mar/14 00:00
• Updated: 20/Dec/14 14:21
• Resolved: 10/Jul/14 08:39

Description

The quickShipEntireOrder in ShipmentServices.xml takes in an optional field called "setPackedOnly". This check for setPackedOnly was added to 'createShipmentForFacilityAndShipGroup' in r1139346. QuickShipEntireOrder also calls the 'createShipmentForFacilityAndShipGroup' simple method, but setPackedOnly is never set in the context before making the call, meaning that setPackedOnly is always empty when it's checked in the method.

Additionally, the check on setPackedOnly is written such that if setPackedOnly is NOT empty, the status is taken to SHIPPED. Instead, it makes sense for it to be taken to SHIPPED status when setPackedOnly IS empty (see 'setShipmentStatusPackedAndShipped' Line 1719).

See my original thread on the ML here: http://ofbiz.135035.n4.nabble.com/Quick-Ship-Order-Status-Service-td4648696.html